Skip to content

Fix CI: stop workflow when build fails, skip artifact upload #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveL-MSFT merged 3 commits into from
Jul 10, 2026
+0 −25
Merged

Fix CI: stop workflow when build fails, skip artifact upload #1620

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ad1d2c
Initial plan
Copilot Jul 10, 2026
bce5c0a
Fix CI: don't upload coverage/tar if build fails
Copilot Jul 10, 2026
0160bd6
remove used id
SteveL-MSFT Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,28 +53,20 @@ jobs:
- name: Install prerequisites
run: ./build.ps1 -SkipBuild -Clippy -Verbose
- name: Build and test with code coverage
id: rust-tests
continue-on-error: true
run: ./build.ps1 -Clippy -Test -CodeCoverage -ExcludePesterTests -Verbose
Comment thread
SteveL-MSFT marked this conversation as resolved.
- name: Upload coverage data
if: always()
uses: actions/upload-artifact@v4
with:
name: linux-coverage
path: lcov.info
if-no-files-found: ignore
- name: Prepare build artifact
if: always()
run: tar -cvf bin.tar bin/
- name: Upload build artifact
if: always()
uses: actions/upload-artifact@v4
with:
name: linux-bin
path: bin.tar
- name: Fail if rust tests failed
if: steps.rust-tests.outcome == 'failure'
run: exit 1
linux-pester:
needs: linux-build
strategy:
Expand Down Expand Up @@ -145,28 +137,20 @@ jobs:
- name: Install prerequisites
run: ./build.ps1 -SkipBuild -Clippy -Verbose
- name: Build and test with code coverage
id: rust-tests
continue-on-error: true
run: ./build.ps1 -Clippy -Test -CodeCoverage -ExcludePesterTests -Verbose
Comment thread
SteveL-MSFT marked this conversation as resolved.
- name: Upload coverage data
if: always()
uses: actions/upload-artifact@v4
with:
name: macos-coverage
path: lcov.info
if-no-files-found: ignore
- name: Prepare build artifact
if: always()
run: tar -cvf bin.tar bin/
- name: Upload build artifact
if: always()
uses: actions/upload-artifact@v4
with:
name: macos-bin
path: bin.tar
- name: Fail if rust tests failed
if: steps.rust-tests.outcome == 'failure'
run: exit 1
macos-pester:
needs: macos-build
strategy:
Expand Down Expand Up @@ -241,31 +225,22 @@ jobs:
- name: Install prerequisites
run: ./build.ps1 -SkipBuild -Clippy -Verbose
- name: Build and test with code coverage
id: rust-tests
continue-on-error: true
run: ./build.ps1 -Clippy -Test -CodeCoverage -ExcludePesterTests -Verbose
Comment thread
SteveL-MSFT marked this conversation as resolved.
- name: Upload coverage data
if: always()
uses: actions/upload-artifact@v4
with:
name: windows-coverage
path: lcov.info
if-no-files-found: ignore
- name: List bin folder files
if: always()
run: Get-ChildItem bin
- name: Prepare build artifact
if: always()
run: tar -cvf bin.tar bin
- name: Upload build artifact
if: always()
uses: actions/upload-artifact@v4
with:
name: windows-bin
path: bin.tar
- name: Fail if rust tests failed
if: steps.rust-tests.outcome == 'failure'
run: exit 1
windows-pester:
needs: windows-build
strategy:
Expand Down
Loading