Skip to content

Fix: RequestHelper silently swallows non-2xx responses, causing false success on Upload & Publish #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix: RequestHelper silently swallows non-2xx responses, causing false success on Upload & Publish #343

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
553d1f5
Initial plan
Copilot Aug 18, 2026
1ccae37
Fix: throw on non-2xx responses in RequestHelper instead of returning…
Copilot Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions src/helpers/requestHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as vscode from "vscode";
import fetch from "node-fetch";
import fetch, { Response } from "node-fetch";
import { v4 as uuid } from "uuid";
import { apiPartUrl, connectionCurrentStoreKey, customDataverseClientId, LoginTypes, maxRetries } from "../utils/Constants";
import { IConnection } from "../utils/Interfaces";
Expand Down Expand Up @@ -46,7 +46,7 @@ export class RequestHelper {
throw new Error("Unable to finish the requested query");
}
} else {
return undefined;
await this.raiseResponseError(response);
}
}
} catch (err) {
Expand Down Expand Up @@ -88,7 +88,7 @@ export class RequestHelper {
throw new Error("Unable to finish the requested query");
}
} else {
return undefined;
await this.raiseResponseError(response);
}
}
} catch (err) {
Expand Down Expand Up @@ -129,14 +129,27 @@ export class RequestHelper {
throw new Error("Unable to finish the requested query");
}
} else {
return undefined;
await this.raiseResponseError(response);
}
}
} catch (err) {
console.log(err);
throw err;
}
}
}

async function redirectTimeout(): Promise<void> {}
private async raiseResponseError(response: Response): Promise<never> {
let message = `Request failed with status ${response.status}`;
try {
const body = (await response.json()) as { error?: { code?: string; message?: string } };
if (body?.error?.message) {
message = body.error.message;
} else if (body?.error?.code) {
message = `Error code: ${body.error.code}`;
}
} catch {
// ignore JSON parse errors; use the default message
}
throw new Error(message);
}
}