fix: satisfy SDK compliance harness 0.8.0#699
Draft
marandaneto wants to merge 1 commit into
Draft
Conversation
marandaneto
changed the title
Contributor
|
Reviews (1): Last reviewed commit: "chore: add SDK compliance harness 0.8.0" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+88
to
+99
| def test_flags_request_uses_token_field_for_project_api_key(): | ||
| mock_response = mock.MagicMock() | ||
| mock_response.status_code = 200 | ||
| mock_response.json.return_value = {"featureFlags": {}} | ||
|
|
||
| with mock.patch.object(request_module, "post", return_value=mock_response) as mock_post: | ||
| flags(TEST_API_KEY, host="https://test.posthog.com", distinct_id="user_1") | ||
|
|
||
| mock_post.assert_called_once() | ||
| assert mock_post.call_args.kwargs["api_key_field"] == "token" | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
The team's convention is to prefer parameterised tests. The new test covers one scenario (flags() sending "token"); a natural companion case — that plain post() defaults to "api_key" — is left untested. Expressing both as a @pytest.mark.parametrize block would keep them together, make the contract explicit, and make adding future cases (e.g. a hypothetical batch_post variant) straightforward.
Context Used: Do not attempt to comment on incorrect alphabetica... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Contributor
posthog-python Compliance ReportDate: 2026-06-27 12:41:06 UTC ✅ All Tests Passed!45/45 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 16/16 tests passed View Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The SDK compliance workflow and local harness need to use SDK test harness release 0.8.0, with reusable GitHub workflow calls pinned to the release commit SHA instead of a mutable tag/branch. Running the updated harness exposed SDK/adapter compliance gaps in this repository.
Changes
Tests