Skip to content

ci: Configure SDK compliance capture suite #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marandaneto wants to merge 1 commit into from
Closed

ci: Configure SDK compliance capture suite #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/sdk-compliance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,11 @@ on:
jobs:
compliance:
name: PostHog SDK compliance tests
uses: PostHog/posthog-sdk-test-harness/.github/workflows/test-sdk-action.yml@be8b8d5a3f94a249659844e94832e874f049c1e4
uses: PostHog/posthog-sdk-test-harness/.github/workflows/test-sdk-action.yml@fix/sdk-harness-options-20260630

@greptile-apps greptile-apps Bot Jun 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 security Mutable branch reference replaces pinned SHA

The original ref (be8b8d5a3f94a249659844e94832e874f049c1e4) was an immutable commit SHA; the new ref (fix/sdk-harness-options-20260630) is a mutable branch in an external repository. Any force-push or new commit to that branch in PostHog/posthog-sdk-test-harness will silently alter the workflow code executed against this repo's CI — a classic supply-chain risk for reusable-workflow consumers. Once the upstream branch is merged and a stable SHA or tag is available, this should be pinned back to an immutable ref.

with:
adapter-dockerfile: "sdk_compliance_adapter/Dockerfile"
adapter-context: "."
test-harness-version: "0.8.0"
suite: "capture"
sdk-type: "server"
continue-on-error: true
2 changes: 1 addition & 1 deletion sdk_compliance_adapter/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ services:

test-harness:
image: ghcr.io/posthog/sdk-test-harness:0.8.0
command: ["run", "--adapter-url", "http://sdk-adapter:8080", "--mock-url", "http://test-harness:8081"]
command: ["run", "--adapter-url", "http://sdk-adapter:8080", "--mock-url", "http://test-harness:8081", "--sdk-type", "server", "--suite", "capture"]
networks:
- test-network
depends_on:
Expand Down
Loading