fix: fall back when payload compression fails#187
Open
marandaneto wants to merge 3 commits into
Open
Conversation
|
Member
Author
|
Addressed the Greptile outside-diff note in c39b0c0 — documented the compressRequest request option in the HttpClient docblock. |
|
Reviews (2): Last reviewed commit: "Fix compression fallback request options" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
When
compress_requestis enabled, local gzip failures should not cause the batch to fail or be dropped before the request is sent. The SDK should send the original payload uncompressed instead.This updates the curl, socket, and forked curl consumers to fall back to the original payload when compression fails, and lets the shared HTTP client omit
Content-Encoding: gzipfor that fallback request.💚 How did you test it?
composer install --no-interaction --no-progress./vendor/bin/phpunit --no-coverage test/QueueConsumerTest.php test/ConsumerLibCurlTest.php test/ConsumerSocketTest.php test/ConsumerForkCurlTest.php📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented as part of a cross-SDK consistency pass for client-side compression failure fallback. Kept the change limited to existing compression-enabled batch upload paths.