Skip to content

perf: dedupe listJobsForWorkflowRun pagination #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
webjunkie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: dedupe listJobsForWorkflowRun pagination #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dist/index.js
View file
Open in desktop

Large diffs are not rendered by default.

66 changes: 32 additions & 34 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,18 +47,23 @@ async function run() {
properties.started_at = workflowRun.run_started_at
}

// Workflow status (from referenced job via GitHub API)
if (statusJob) {
let targetJob = null
// Fetch all jobs once if any feature needs them (status-job or capture-job-durations)
let allJobs = null
if (statusJob || captureJobDurations) {
allJobs = []
for await (const response of octokit.paginate.iterator(octokit.rest.actions.listJobsForWorkflowRun, {
owner: github.context.repo.owner,
repo: github.context.repo.repo,
run_id: github.context.runId,
per_page: 100,
})) {
targetJob = response.data.find(j => j.name === statusJob)
if (targetJob) break
allJobs.push(...response.data)
}
}

// Workflow status (from referenced job)
if (statusJob) {
const targetJob = allJobs.find(j => j.name === statusJob)
if (targetJob) {
properties.conclusion = targetJob.conclusion
} else {
Expand Down Expand Up @@ -105,35 +110,28 @@ async function run() {
})
}

for await (const response of octokit.paginate.iterator(octokit.rest.actions.listJobsForWorkflowRun, {
owner: github.context.repo.owner,
repo: github.context.repo.repo,
run_id: github.context.runId,
per_page: 100,
})) {
for (const job of response.data) {
// Skip jobs that haven't completed or are the metrics job itself
if (!job.completed_at || job.name === github.context.job) continue

const durationSeconds = Math.floor(
(new Date(job.completed_at) - new Date(job.started_at)) / 1000
)

client.capture({
distinctId: 'posthog-github-action',
event: `${eventName}-job`,
properties: {
name: job.name,
duration_seconds: durationSeconds,
conclusion: job.conclusion,
started_at: job.started_at,
completed_at: job.completed_at,
runner: job.runner_name,
...githubContext,
},
groups: { workflow_run: workflowRunGroup },
})
}
for (const job of allJobs) {
// Skip jobs that haven't completed or are the metrics job itself
if (!job.completed_at || job.name === github.context.job) continue

const durationSeconds = Math.floor(
(new Date(job.completed_at) - new Date(job.started_at)) / 1000
)

client.capture({
distinctId: 'posthog-github-action',
event: `${eventName}-job`,
properties: {
name: job.name,
duration_seconds: durationSeconds,
conclusion: job.conclusion,
started_at: job.started_at,
completed_at: job.completed_at,
runner: job.runner_name,
...githubContext,
},
groups: { workflow_run: workflowRunGroup },
})
}
}

Expand Down
Loading