Skip to content

fix(updates): show skeleton while release notes load #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlesvien merged 1 commit into from
Jun 30, 2026
+4 −9
Merged

fix(updates): show skeleton while release notes load #3038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions packages/ui/src/features/updates/UpdateAvailableModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { X } from "@phosphor-icons/react";
import { useHostTRPC } from "@posthog/host-router/react";
import { MarkdownRenderer } from "@posthog/ui/features/editor/components/MarkdownRenderer";
import { ReleaseNotesSections } from "@posthog/ui/features/updates/ReleaseNotesSections";
import { parseReleaseNotes } from "@posthog/ui/features/updates/releaseNotes";
import { useUpdateModalStore } from "@posthog/ui/features/updates/updateModalStore";
Expand Down Expand Up @@ -63,7 +62,7 @@ export function UpdateAvailableModal() {
const downloadMutation = useMutation(
hostTRPC.updates.download.mutationOptions(),
);
const { data: releasesData, isLoading: isLoadingReleases } = useQuery({
const { data: releasesData, isPending: isPendingReleases } = useQuery({
...hostTRPC.githubReleases.list.queryOptions(),
enabled: isOpen,
});
Expand Down Expand Up @@ -115,7 +114,7 @@ export function UpdateAvailableModal() {
</Dialog.Close>
</Flex>

{hasParsedNotes || rawNotes || isLoadingReleases ? (
{hasParsedNotes || isPendingReleases ? (
<Flex direction="column" gap="2">
<Text
size="1"
Expand All @@ -125,18 +124,14 @@ export function UpdateAvailableModal() {
>
Release notes
</Text>
{hasParsedNotes || rawNotes ? (
{hasParsedNotes && parsedNotes ? (
<ScrollArea
type="auto"
scrollbars="vertical"
style={{ maxHeight: 240 }}
>
<div className="pr-3">
{hasParsedNotes && parsedNotes ? (
<ReleaseNotesSections notes={parsedNotes} />
) : rawNotes ? (
<MarkdownRenderer content={rawNotes} />
) : null}
<ReleaseNotesSections notes={parsedNotes} />
</div>
</ScrollArea>
) : (
Expand Down
Loading