fix(cloud-task): lower session-log history page request size#3029
Closed
tatoalo wants to merge 1 commit into
Closed
fix(cloud-task): lower session-log history page request size#3029tatoalo wants to merge 1 commit into
tatoalo wants to merge 1 commit into
Conversation
Request fewer entries per session_logs page so the first history page on bootstrap stays small, complementing the server-side per-page byte cap. Aligns the client page size with the backend default.
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix(cloud-task): lower session-log histo..." | Re-trigger Greptile |
tatoalo
added
the
Stamphog
Contributor
Author
|
closing, since BE gate is enough |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On bootstrap the cloud-task watcher loads run history by paging
session_logs. With the page size at 5,000 entries, the first page of a long run can be many MB and fail to transfer within the watcher's per-request fetch timeout, so it retries indefinitely and the run is stuck "Connecting to your cloud runner" even though it is healthy.Changes
Lower
SESSION_LOG_PAGE_LIMITfrom 5,000 to 1,000 so the first (and every) history page request stays small