You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
scripts/optimize-onboarding-videos.mjs, line 848-855 (link)
Leftover temp files can accumulate in the assets directory
If the script is killed between the execFileSync (ffmpeg writes <file>.opt.mp4) and the renameSync (overwrites the original), a stray *.opt.mp4 file is left in ASSET_DIR. On the next run that file is picked up by readdirSync, passes the .mp4 filter, and isOptimized returns true (ffmpeg wrote the comment marker into it), so it is printed as skip code-review-dark.mp4.opt.mp4 (already optimized) and permanently accumulates in the source tree until deleted manually.
A simple guard at the scan site would prevent this: filter out names that contain .opt.mp4 or optionally delete any leftover temp files at startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
onboarding needed some slick screenshots and videos
Changes
added some slick screenshots and videos
also there's a new skill and script for optimizing the videos and making the screenshot "posters" from the videos if these get updated in the future
How did you test this?
manually
Automatic notifications