Skip to content

feat(code): add videos to onboarding bento box#3024

Merged
adboio merged 1 commit into
mainfrom
06-29-feat_code_add_videos_to_onboarding_bento_box
Jun 30, 2026
Merged

feat(code): add videos to onboarding bento box#3024
adboio merged 1 commit into
mainfrom
06-29-feat_code_add_videos_to_onboarding_bento_box

Conversation

@adboio

@adboio adboio commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Problem

onboarding needed some slick screenshots and videos

Changes

added some slick screenshots and videos

phc-onboarding-screenshots-light.mp4 (uploaded via Graphite)
phc-onboarding-screenshots.mp4 (uploaded via Graphite)

also there's a new skill and script for optimizing the videos and making the screenshot "posters" from the videos if these get updated in the future

How did you test this?

manually

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

adboio commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

React Doctor found 2 issues in 2 files · 2 warnings.

2 warnings

src/features/onboarding/components/FeatureBentoCard.tsx

src/features/onboarding/components/WelcomeScreen.tsx

Reviewed by React Doctor for commit 29a61b0.

@adboio adboio marked this pull request as ready for review June 30, 2026 13:06
@adboio adboio force-pushed the 06-29-feat_code_add_videos_to_onboarding_bento_box branch from ccd3409 to 29a61b0 Compare June 30, 2026 13:08
@greptile-apps

greptile-apps Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Comments Outside Diff (1)

  1. scripts/optimize-onboarding-videos.mjs, line 848-855 (link)

    P2 Leftover temp files can accumulate in the assets directory

    If the script is killed between the execFileSync (ffmpeg writes <file>.opt.mp4) and the renameSync (overwrites the original), a stray *.opt.mp4 file is left in ASSET_DIR. On the next run that file is picked up by readdirSync, passes the .mp4 filter, and isOptimized returns true (ffmpeg wrote the comment marker into it), so it is printed as skip code-review-dark.mp4.opt.mp4 (already optimized) and permanently accumulates in the source tree until deleted manually.

    A simple guard at the scan site would prevent this: filter out names that contain .opt.mp4 or optionally delete any leftover temp files at startup.

Reviews (1): Last reviewed commit: "feat(code): add videos to onboarding ben..." | Re-trigger Greptile

@adboio adboio merged commit b8e8afd into main Jun 30, 2026
24 checks passed

adboio commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

@adboio adboio deleted the 06-29-feat_code_add_videos_to_onboarding_bento_box branch June 30, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants