fix(styles): use semantic colors for plan markdown styling#2901
Open
MattPua wants to merge 1 commit into
Open
Conversation
Generated-By: PostHog Code
Contributor
|
Reviews (1): Last reviewed commit: "chore(styles): use semantic color variab..." | Re-trigger Greptile |
adamleithp
reviewed
Jun 24, 2026
adamleithp
left a comment
Contributor
There was a problem hiding this comment.
Hmm not sure if blue is on brand, I was trying to go with more Posthog.com stylin' ala @corywatilo
Member
Author
i found the styling originally there jarring to read considering the constrast difference, and how often its used in the plan. plus on dark mode its basically non noticeable. I agree about whether blue is the right color at all, but the plan was already blue so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Replace hardcoded rgba colors with semantic color variables in plan markdown styling to ensure consistent visibility and appropriate contrast in both light and dark modes.
Problem
Plan highlighting lacks proper contrast and visibility across different color schemes. The hardcoded
rgba(0, 0, 0, ...)andrgba(255, 255, 255, ...)values don't adapt well to light and dark modes, resulting in unclear highlighting and jarring visual presentation.Changes
Before:
After
background: rgba(0, 0, 0, 0.2)withvar(--blue-a5)for code inline backgroundbackground: rgba(0, 0, 0, 0.25)withvar(--blue-a3)for pre-formatted code block backgroundborder: 1px solid rgba(255, 255, 255, 0.2)withvar(--blue-a6)for table cell bordersborder-left: 2px solid rgba(255, 255, 255, 0.3)withvar(--blue-a6)for blockquote left borderHow did you test this?
Visual inspection of plan markdown rendering in both light and dark modes to verify improved contrast and consistent visibility.
Automatic notifications
Created with PostHog Code