Skip to content

fix(inbox): Show real PR status in inbox list rows #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Twixes wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −19
Open

fix(inbox): Show real PR status in inbox list rows #2056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions apps/code/src/renderer/features/inbox/components/utils/ReportCardContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,7 @@ export function ReportCardContent({
)}
</Flex>
{report.implementation_pr_url && (
<ReportImplementationPrLink
prUrl={report.implementation_pr_url}
skipStatusFetch={compact}
/>
<ReportImplementationPrLink prUrl={report.implementation_pr_url} />
)}
</Flex>

Expand Down
23 changes: 8 additions & 15 deletions apps/code/src/renderer/features/inbox/components/utils/ReportImplementationPrLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@ interface ReportImplementationPrLinkProps {
prUrl: string;
/** `sm`: inbox list row. `md`: implementation task panel bar. */
size?: ImplementationPrLinkSize;
/**
* When true, skips the tRPC/GitHub status fetch and renders the badge in the
* default open state. Use in list rows to avoid N parallel API calls on mount.
*/
skipStatusFetch?: boolean;
}

function parseGitHubPrReference(prUrl: string): {
Expand Down Expand Up @@ -46,22 +41,20 @@ function parseGitHubPrReference(prUrl: string): {
export function ReportImplementationPrLink({
prUrl,
size = "sm",
skipStatusFetch = false,
}: ReportImplementationPrLinkProps) {
const {
meta: { state, merged, isLoading },
} = usePrDetails(skipStatusFetch ? null : prUrl);
} = usePrDetails(prUrl);

const isSm = size === "sm";

const colorClass =
isLoading || skipStatusFetch
? "bg-green-4 text-green-11 hover:bg-green-5"
: merged
? "bg-violet-4 text-violet-11 hover:bg-violet-5"
: state === "closed"
? "bg-red-4 text-red-11 hover:bg-red-5"
: "bg-green-4 text-green-11 hover:bg-green-5";
const colorClass = isLoading
? "bg-gray-4 text-gray-11 hover:bg-gray-5"
: merged
? "bg-violet-4 text-violet-11 hover:bg-violet-5"
: state === "closed"
? "bg-red-4 text-red-11 hover:bg-red-5"
: "bg-green-4 text-green-11 hover:bg-green-5";

const { reference: prReference, prNumber } = parseGitHubPrReference(prUrl);

Expand Down
Loading