Skip to content

Fix TRO regen in Versioning job: resolve path from script; allow empty writes #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxGhenis merged 1 commit into from
Apr 18, 2026
Merged

Fix TRO regen in Versioning job: resolve path from script; allow empty writes #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions scripts/generate_trace_tros.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@
If a country previously had a TRO on disk and the new run cannot
regenerate it (e.g. a missing secret or an unreachable HF endpoint),
the script exits non-zero so the release workflow blocks rather than
silently shipping a stale/missing TRO.
silently shipping a stale/missing TRO. If no bundled release manifests
are found at all, the script exits 0 with a notice (nothing to do).
"""

from __future__ import annotations

import sys
from importlib.resources import files
from pathlib import Path

from policyengine.core.release_manifest import (
Expand All @@ -28,14 +28,19 @@
serialize_trace_tro,
)

MANIFEST_DIR = (
Path(__file__).resolve().parent.parent
/ "src"
/ "policyengine"
/ "data"
/ "release_manifests"
)


def regenerate_all() -> tuple[list[Path], list[tuple[str, Path, str]]]:
manifest_root = Path(
str(files("policyengine").joinpath("data", "release_manifests"))
)
written: list[Path] = []
regressions: list[tuple[str, Path, str]] = []
for manifest_path in sorted(manifest_root.glob("*.json")):
for manifest_path in sorted(MANIFEST_DIR.glob("*.json")):
country_id = manifest_path.stem
tro_path = manifest_path.with_suffix(".trace.tro.jsonld")
country_manifest = get_release_manifest(country_id)
Expand All @@ -61,6 +66,9 @@ def regenerate_all() -> tuple[list[Path], list[tuple[str, Path, str]]]:


def main() -> int:
if not MANIFEST_DIR.is_dir():
print(f"no manifest dir at {MANIFEST_DIR}", file=sys.stderr)
return 1
written, regressions = regenerate_all()
for path in written:
print(f"wrote {path}")
Expand All @@ -73,8 +81,7 @@ def main() -> int:
if regressions:
return 1
if not written:
print("no release manifests found", file=sys.stderr)
return 1
print("no countries could be regenerated (all skipped)", file=sys.stderr)
return 0


Expand Down