Conversation
PE-core 3.24.0-3.24.3 cache-invalidation wiped set_input values across apply_reform, which in policyengine-us manifested as state_fips getting cleared and the downstream state_name/state_code chain returning None (#8058). 3.25.0 preserves user inputs while still invalidating formula-output caches. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…f fix PE-core 3.25.0 regressed YAML full-suite run time (17 min -> 51+ min per job, hit 1-hour GH Actions timeout) because `_invalidate_all_caches` walked every variable in the tax-benefit system and lazy-created a Holder for each. Fixed upstream in PolicyEngine/policyengine-core#478 by iterating only existing holders, restoring the original sub-second `apply_reform` cost. 3.25.1 ships the fix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
MaxGhenis
force-pushed
the
bump-pe-core-3.25
branch
from
5b29773 to
072031a
Compare
Contributor
Author
|
Multiple reruns have all hit GitHub Actions runner preemptions ( Key points for reviewer:
Leaving this open in case someone wants to retry when the runner fleet stabilises, or close if the 3.24.4 baseline from #8078 is good enough for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
policyengine-coreminimum to>=3.25.1to pick up:set_inputpreservation fix (Preserve set_input values across apply_reform policyengine-core#475) — closes Add regression test for parameter breakdown mismatch (closes #8055) #8058 whereapply_reformwipedstate_fipsand broke thestate_name/state_codechain._invalidate_all_cachesperformance fix (Fix _invalidate_all_caches performance regression policyengine-core#478) — the initial 3.25.0 version walked every variable in the tax-benefit system and lazy-created a Holder for each, which blew up the YAML full-suite from ~17 min to ~51 min per job and started hitting the 1-hour GitHub Actions timeout. 3.25.1 iterates only existing holders.Supersedes the closed #8070 which bumped to 3.25.0 and hit the perf regression.
Test plan
tests/test_ctc_itemizing_branch_cyclepasses locallyGenerated with Claude Code