Add exact geography loader seam#759
Open
anth-volk wants to merge 11 commits intocodex/h5-migration-pr2-typed-request-constructionfrom
Open
Add exact geography loader seam#759anth-volk wants to merge 11 commits intocodex/h5-migration-pr2-typed-request-constructionfrom
anth-volk wants to merge 11 commits intocodex/h5-migration-pr2-typed-request-constructionfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
e076b94 to
25060c9
Compare
d92611c to
ddee97f
Compare
88ee846 to
cf9841e
Compare
a338f7e to
f848260
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #757
This is PR 3a in the incremental local H5 migration stack.
What this PR does:
policyengine_us_data/calibration/local_h5/geography_loader.pyCalibrationGeographyLoaderas the internal owner of exact geography resolutiongeography_assignment.npz, package-backed geography when available, and legacystacked_blocks.npyfallbackpublish_local_area.load_calibration_geography(...)as a compatibility wrapper over the new seamWhat this PR does not do:
Compatibility boundary:
Testing:
python -m py_compile policyengine_us_data/calibration/local_h5/geography_loader.py policyengine_us_data/calibration/publish_local_area.py tests/unit/calibration/fixtures/test_local_h5_geography_loader.py tests/unit/calibration/test_local_h5_geography_loader.pyruff check --ignore E402 policyengine_us_data/calibration/local_h5/geography_loader.py policyengine_us_data/calibration/publish_local_area.py tests/unit/calibration/fixtures/test_local_h5_geography_loader.py tests/unit/calibration/test_local_h5_geography_loader.pypython -m pytest --noconftest tests/unit/calibration/test_local_h5_geography_loader.py -q5 passed