Change hours_worked label to 'Hours worked per week'#1609
Conversation
The variable represents weekly hours (used as hours/52 for weekly_hours and hours*52 for annual calculations), so the label should reflect this. Fixes #451. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The proposed label "Hours worked per week" contradicts how
So If the intent is to make it friendlier, the accurate replacement is something like "Annual hours worked". If you'd rather change the semantics to weekly, that's a much bigger change — we'd also need to update Flagging as blocking until one of those is chosen. Happy to push a one-line change to "Annual hours worked" if that's what you want. |
hours_worked is annual: FRS input builds it as tothours * 52, and weekly_hours divides it by WEEKS_IN_YEAR. A "per week" label would misrepresent the variable by a factor of 52. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Good catch — you're right,
Pushed 3d82a25c changing the label to "Annual hours worked" and updated the changelog entry to match. Keeping semantics as-is — not switching to weekly. |
MaxGhenis
left a comment
There was a problem hiding this comment.
Verified against the formula: weekly_hours = hours_worked / WEEKS_IN_YEAR, so hours_worked is annual. The updated label "Annual hours worked" matches. The PR title/body still say "per week" — that was an earlier draft; the actual diff is correct. Approving.
Summary
hours_workedvariable label from "Total amount of hours worked by this person" to "Hours worked per week"WEEKS_IN_YEARforweekly_hours, multiplied by 52 for annual wage calculations)Fixes #451
Test plan
🤖 Generated with Claude Code