RowDetail: contain the per-release table; wrap long tokens (fixes overlapping text on BE rows) - #85
Merged
Merged
Conversation
Max hit overlapping text on the expanded Belgium rows: the per-release table's min-content width (engine 'rulespec-be@<40-hex>' pins, construction JSON labels) exceeded its md:grid-cols-2 track, and grid items default to min-width:auto, so the table painted across the Claim panel. - min-w-0 on both grid columns so they can actually shrink; - break-all on the engine and construction cells (the unbroken tokens); - break-words on the claim metadata/conditions paragraphs (sha pins, slugs); - overflow-x-auto around the table as containment for any future wide cell. DOM-measured before/after on the BE row: table 626px in a 447px column (163px painted over the sibling) -> 447px, overlap 0. Presentation-only; no data or logic changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Max hit overlapping text on the expanded Belgium claim rows (screenshot in chat): the per-release table's min-content width — engine
rulespec-be@<40-hex>pins and construction JSON labels, first stressed by the BE rows — exceeded itsmd:grid-cols-2track. Grid items default tomin-width: auto, so the table painted across the Claim panel.Fix:
min-w-0on both grid columns,break-allon the engine + construction cells,break-wordson the claim metadata/conditions paragraphs, and anoverflow-x-autowrapper as containment for any future wide cell.DOM-measured on the live BE row: table 626px in a 447px column (163px overlap) → 447px, overlap 0px. oxlint, tsc, bun tests, production build all green. Presentation-only — no data or logic changes, so shipped on CI without a sol round; the claim-content gate was #82's five-round review.
🤖 Generated with Claude Code