Default US metadata to Populace#3715
Merged
Merged
Conversation
0a93bc5 to
158817f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3715 +/- ##
=======================================
Coverage 78.81% 78.81%
=======================================
Files 71 71
Lines 4320 4320
Branches 804 804
=======================================
Hits 3405 3405
Misses 702 702
Partials 213 213 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- advertise the certified Populace bundle as the default US economy dataset in metadata\n- keep legacy CPS and enhanced CPS as explicit non-default options\n- add a regression test so app-v2 continues to omit dataset= for default Populace runs\n\nThis complements PolicyEngine/populace#228, which makes the sparse L0+refit build the default release artifact. API economy runs already omit the concrete data field for dataset=default, allowing the simulation gateway/policyengine.py bundle to resolve the certified Populace dataset and apply state/CD row filters.\n\n## Tests\n- uv run ruff format policyengine_api/country.py tests/unit/services/test_metadata_service.py\n- uv run ruff check policyengine_api/country.py tests/unit/services/test_metadata_service.py\n- uv run pytest tests/unit/services/test_metadata_service.py tests/unit/services/test_economy_service.py::TestEconomicImpactSetupOptions::TestSetupSimOptions tests/unit/libs/test_simulation_api_modal.py::TestSimulationAPIModal::TestRun::test__given_api_v1_default_bundle_payload__then_posts_gateway_contract_body