Skip to content

Install importlib-metadata explicitly in Modal images #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anth-volk wants to merge 1 commit into from
Closed

Install importlib-metadata explicitly in Modal images #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/policyengine-api-simulation/src/modal/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,10 @@ def build_base_simulation_image() -> modal.Image:
"fastapi>=0.115.0",
"tables>=3.10.2",
"logfire>=3.0.0",
# logfire imports importlib_metadata unconditionally but does
# not declare it as a dependency on Python 3.13, so install it
# explicitly or workers crash on ``import logfire``.
"importlib-metadata>=8",
"policyengine-observability[fastapi]>=1.3.0,<2",
)
.run_commands(
Expand Down
4 changes: 4 additions & 0 deletions projects/policyengine-api-simulation/src/modal/gateway/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@
# the auth module at runtime here.
"cryptography>=41.0.0",
"logfire>=3.0.0",
# logfire imports importlib_metadata unconditionally but does not
# declare it as a dependency on Python 3.13, so install it
# explicitly or the container crashes at startup.
"importlib-metadata>=8",
"policyengine-observability[fastapi]>=1.3.0,<2",
)
.add_local_python_source(
Expand Down
7 changes: 7 additions & 0 deletions projects/policyengine-api-simulation/tests/test_modal_bundle_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,10 @@ def test_modal_image_uses_policyengine_bundle_install(monkeypatch):
packages = pip_install_calls[0][1]
assert "policyengine-observability[fastapi]>=1.3.0,<2" in packages
assert "logfire>=3.0.0" in packages
# logfire needs importlib_metadata at import time on Python 3.13 but
# does not declare it; without the explicit install every worker
# crashes on ``import logfire``.
assert "importlib-metadata>=8" in packages

runtime_secret_sets = {
name: kwargs["secrets"] for name, kwargs in app.app.function_calls
Expand Down Expand Up @@ -164,6 +168,9 @@ def test_gateway_image_installs_dual_observability(monkeypatch):
packages = pip_install_calls[0][1]
assert "policyengine-observability[fastapi]>=1.3.0,<2" in packages
assert "logfire>=3.0.0" in packages
# Same importlib_metadata gap as the simulation image: without this the
# gateway ASGI factory dies in configure_logfire and every request 303s.
assert "importlib-metadata>=8" in packages

function_kwargs = {name: kwargs for name, kwargs in app.app.function_calls}
assert function_kwargs["web_app"]["secrets"] == [
Expand Down