Add Ledger governance and raw fact boundary checks#68
Merged
Conversation
d8223fe to
f84b4b1
Compare
f84b4b1 to
add0017
Compare
…oundary-20260630 # Conflicts: # tests/test_ledger_source_cells.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ledgerthe only CLI entry pointmicro/,calibration/,ledger.microdata,policyengine_ledger.microdata, raw CPS/PUF/FRS adapters, tracked rawstorage/, and obsolete tests/docsmicroplex,policyengine-us,scipy, and related simulator/calibration dependency paths from package metadata and lockfileruntime_code,python_code,solver,module,command, andexecute, including nested profile contractspolicyengine_ledgerwrapper imports aligned with the renamedledgerpackageorigin/mainafter the repo rename and convert the newly added ONS/HMRC UK firm source packages to Ledger schema/raw-evidence conventionsVerification
uv run ruff format --check ledger policyengine_ledger db scripts testsuv run ruff check ledger policyengine_ledger db scripts testsuv run ruff format --check policyengine_ledger/target_profiles/model.py tests/test_policyengine_ledger_target_profiles.pyuv run ruff check policyengine_ledger/target_profiles/model.py tests/test_policyengine_ledger_target_profiles.pyuv run ruff format --check policyengine_ledger/target_profiles/model.py policyengine_ledger/targets/__init__.pyuv run ruff check policyengine_ledger/target_profiles/model.py policyengine_ledger/targets/__init__.pygit diff --checkandgit diff --cached --checkuv run pytest tests/test_ledger_governance.py tests/test_ledger_namespace.py tests/test_policyengine_ledger_imports.py tests/test_ledger_boundaries.py tests/test_ledger_core.py tests/test_supabase_client.py -q— 30 passed, 1 skippeduv run pytest tests/test_policyengine_ledger_target_profiles.py tests/test_ledger_governance.py tests/test_ledger_boundaries.py -q— 23 passeduv run pytest tests/test_policyengine_ledger_target_profiles.py tests/test_ledger_boundaries.py -q— 21 passedPYTHONDONTWRITEBYTECODE=1 uv run pytest -p no:cacheprovider tests/test_policyengine_ledger_target_profiles.py tests/test_ledger_boundaries.py tests/test_policyengine_ledger_imports.py -q— 27 passed after deleting tracked rawstorage/uv run pytest -q— 511 passed, 1 skipped, 14 warningsuv build/tmp/ledger-wheel-smokePython 3.14 venvenv -u UV_FROZEN uv lockrg -n "microplex|Microplex|MICROPLEX" . -g "!*.pyc"— no matchesmicro/,calibration/,storage/,ledger/microdata/, andpolicyengine_ledger/microdata/are absent from the checkout after cleanupReview
/cycleread-only review on the rename/boundary work; first pass found stale Arch wording in packaged docstrings/comments, fixed it, and the latest pass reported no actionable findings.scipy,policyengine-us, and downstream compiler-plan remnants; all three were fixed in076b107.9d63eaband8fc59c4.e6f1acffound no actionable findings; it confirmedstorage/pu2023_slim.csvis gone, no tracked raw-data namespaces remain, Microplex references are absent, and runtime-like profile keys are recursively forbidden.