Skip to content

Fix move effects for Sword and Shield - #1641

Open
notblisy wants to merge 8 commits into
PokeAPI:masterfrom
notblisy:fix-move-effects-g7+
Open

Fix move effects for Sword and Shield#1641
notblisy wants to merge 8 commits into
PokeAPI:masterfrom
notblisy:fix-move-effects-g7+

Conversation

@notblisy

Copy link
Copy Markdown
Contributor

Change description

With the addition of all of Sword/Shield encounters to the API, I noticed the move effects were all out of whack as well.

  • Add, update, or fix all move effects for sword+shield and its two DLCs.
  • This adds things to 3 files. Moves.csv, move_effects.csv, and move_effect_prose.csv
  • I got most of the effect details from smogon, but looked at other similar effects in the API and reworded it to be consistent with this.

AI coding assistance disclosure

  • No AI was used.

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant