-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Adding Gen 6 Ambush Encounters #1576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
ebe9fdd
74a9c6c
2539721
9d1529f
3c92cde
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,3 +24,5 @@ id,identifier | |
| 23,save-data | ||
| 24,alolan-diglett-found | ||
| 25,weather | ||
| 26,berry-tree-type | ||
| 27,trash-can-type | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -18,7 +18,7 @@ id,identifier,order | |||||
| 17,rough-terrain,9 | ||||||
| 18,gift,18 | ||||||
| 19,gift-egg,19 | ||||||
| 20,only-one,20 | ||||||
| 20,static-encounter,20 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Maybe just 'static', since these are all methods for encountering pokemon. |
||||||
| 21,pokeflute,21 | ||||||
| 22,headbutt-low,22 | ||||||
| 23,headbutt-normal,23 | ||||||
|
|
@@ -55,3 +55,8 @@ id,identifier,order | |||||
| 54,hidden-grotto,54 | ||||||
| 55,honey-tree,55 | ||||||
| 56,overworld-dirt,56 | ||||||
| 57,trash-can,57 | ||||||
| 58,rustling-bush-ambush,58 | ||||||
| 59,ceiling-ambush,59 | ||||||
| 60,ground-ambush,60 | ||||||
| 61,sky-ambush,61 | ||||||
|
Comment on lines
+58
to
+62
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a great start on the new methods! Looking at Bulbapedia, some of these are even used again in Alola, so this will be helpful there too. Regarding the names, maybe they should all contain 'ambush'? So something like |
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1255,3 +1255,4 @@ id,location_id,game_index,identifier | |
| 1374,945,0,gym | ||
| 1375,880,0,gym | ||
| 1376,1116,0, | ||
| 1377,1117,0, | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally the encounter condition values' identifiers start with the encounter condition identifier. For example, for
berry-tree-typewe'd use something likeberry-tree-type-blueand so on.