Add x11 on linux when vtk 9.6+#6435
Open
daeho-ro wants to merge 1 commit intoPointCloudLibrary:masterfrom
Open
Add x11 on linux when vtk 9.6+#6435daeho-ro wants to merge 1 commit intoPointCloudLibrary:masterfrom
daeho-ro wants to merge 1 commit intoPointCloudLibrary:masterfrom
Conversation
1 task
mvieth
added
module: visualization
module: cmake
changelog: fix
Member
|
Thank you for the pull request. I tried to reproduce the problem by building PCL with VTK 9.6, but everything was fine. Maybe that is just because the X11 includes are in the standard include path on my computer ( |
Author
|
Nothing else, that is all I think. In our CI on macos, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that
vtkis no longer requiredx11, it is an optional. So I think it should be added explicitely here for safety.