Fix overlay scrollbar intercepting clicks on selection handles at image edges (#2200)#2201
Open
AoMas17 wants to merge 1 commit into
Open
Fix overlay scrollbar intercepting clicks on selection handles at image edges (#2200)#2201AoMas17 wants to merge 1 commit into
AoMas17 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2200 by preventing overlay scrollbars from capturing pointer events when the current tool is interacting with a selection resize handle near the canvas edge.
When a rectangle or ellipse selection reaches the image boundary and the canvas is zoomed in enough for scrollbars to appear, the scrollbar can overlap the resize handle and block interaction. With this change, the selection tool temporarily keeps the scrollbar from targeting pointer events while the cursor is over an active handle, so the handle remains draggable as expected.
I also attached a before/after video showing the problem and the fix in action.
This is my first contribution to Pinta, so I'm not yet familiar with the project's roadmap or preferred development practices. I'm very open to feedback and happy to rework any part of this PR if needed.
before.mp4
after.mp4