Fix: Set CMP0135 to NEW to silence FetchContent timestamp warnings - #6
Open
fdavulcu wants to merge 1 commit into
Open
Fix: Set CMP0135 to NEW to silence FetchContent timestamp warnings#6fdavulcu wants to merge 1 commit into
fdavulcu wants to merge 1 commit into
Conversation
…STAMP Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
fdavulcu
force-pushed
the
fix/fetchcontent-timestamp-warning
branch
from
August 19, 2026 13:56
d6c5d95 to
57a7f87
Compare
fdavulcu
changed the title
fdavulcu
marked this pull request as ready for review
August 19, 2026 15:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[written by AI]
CMake 3.24+ warns (CMP0135) on every
FetchContent_DeclareURL download that neither setsDOWNLOAD_EXTRACT_TIMESTAMPnor the policy, once per configure ofkortex_apiandkortex_driver. Setcmake_policy(SET CMP0135 NEW)behind anif(POLICY ...)guard in both packages: extracted files get extraction-time timestamps, so a changed download URL correctly triggers dependent rebuilds, and the guard keeps the declaredcmake_minimum_required(VERSION 3.14)floor working on pre-3.24 CMake, where the policy (and the warning) do not exist.DOWNLOAD_EXTRACT_TIMESTAMPwas deliberately not used: the keyword only exists since CMake 3.24 (older FetchContent passes it through toExternalProject_Addand breaks configure), and thetruevalue the warning text suggests selects the legacy archive-timestamp behavior CMP0135 exists to replace, which can suppress rebuilds after an archive update.