Fix: Stabilize weekly sim objective integration#751
Merged
Conversation
|
JWhitleyWork
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes PickNikRobotics/moveit_pro#19978.
The weekly example workspace integration run failed across the expanded sim matrix. The failures were headless-CI mismatches rather than regressions in the objectives:
TeleoperateandMarker Visualization Exampleare core objectives aggregated into each config, but require a connected UI.april_tag_siminherits fromlab_sim, but did not declare that package dependency, so its isolated weekly build could collect zero tests withpackage 'lab_sim' not found.Brief description
lab_simas anapril_tag_simruntime dependency socolcon build --packages-up-to april_tag_siminstalls its inherited base config.skip_objectivesentries for the weekly sim objectives that the 2026-06-28 run proved cannot execute deterministically in the headless backend.How it was tested
april_tag_sim/package.xmldeclareslab_simas anexec_depend.pre-commit run --files src/april_tag_sim/package.xml src/april_tag_sim/test/objectives_integration_test.py src/dual_arm_sim/test/objectives_integration_test.py src/factory_sim/test/objectives_integration_test.py src/grinding_sim/test/objectives_integration_test.py src/kitchen_sim/test/objectives_integration_test.pypre-commit run -aFull weekly integration validation is expected to run in CI for this PR; the local dev container is not running in this workspace.
Release notes
None