Skip to content

Fix: Stabilize weekly sim objective integration#751

Merged
JWhitleyWork merged 1 commit into
mainfrom
fix/example-ws-weekly-19978
Jun 30, 2026
Merged

Fix: Stabilize weekly sim objective integration#751
JWhitleyWork merged 1 commit into
mainfrom
fix/example-ws-weekly-19978

Conversation

@marty-mcfly-bot

Copy link
Copy Markdown

Motivation

Closes PickNikRobotics/moveit_pro#19978.

The weekly example workspace integration run failed across the expanded sim matrix. The failures were headless-CI mismatches rather than regressions in the objectives:

  • Teleoperate and Marker Visualization Example are core objectives aggregated into each config, but require a connected UI.
  • Several weekly-only demo objectives time out or fail planning as standalone success checks in headless CI.
  • april_tag_sim inherits from lab_sim, but did not declare that package dependency, so its isolated weekly build could collect zero tests with package 'lab_sim' not found.

Brief description

  • Added lab_sim as an april_tag_sim runtime dependency so colcon build --packages-up-to april_tag_sim installs its inherited base config.
  • Added explicit skip_objectives entries for the weekly sim objectives that the 2026-06-28 run proved cannot execute deterministically in the headless backend.
  • Mirrored the existing lab/hangar rationale for core UI-dependent objectives in the newly-expanded weekly sim test packages.

How it was tested

  • Inspected the failing weekly run logs from PickNikRobotics/moveit_pro_example_ws/actions/runs/28314891660.
  • Ran an ad-hoc verifier that asserts:
    • april_tag_sim/package.xml declares lab_sim as an exec_depend.
    • Each newly skipped local objective ID exists in that config package's objective XML.
    • The updated skip sets contain the expected core UI-dependent objectives.
  • pre-commit run --files src/april_tag_sim/package.xml src/april_tag_sim/test/objectives_integration_test.py src/dual_arm_sim/test/objectives_integration_test.py src/factory_sim/test/objectives_integration_test.py src/grinding_sim/test/objectives_integration_test.py src/kitchen_sim/test/objectives_integration_test.py
  • pre-commit run -a

Full weekly integration validation is expected to run in CI for this PR; the local dev container is not running in this workspace.

Release notes

None

@github-actions

Copy link
Copy Markdown

MoveIt Pro Example WS - Objectives Integration Test Report

@JWhitleyWork JWhitleyWork marked this pull request as ready for review June 30, 2026 19:30
@JWhitleyWork JWhitleyWork merged commit 366c964 into main Jun 30, 2026
39 of 47 checks passed
@JWhitleyWork JWhitleyWork deleted the fix/example-ws-weekly-19978 branch June 30, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant