Skip to content

replace lowest/max double bounds with +/- infinity #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christianrauch wants to merge 3 commits into
base: main
Choose a base branch
from
Open

replace lowest/max double bounds with +/- infinity #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a008c1
replace lowest/max double bounds with +/- infinity
christianrauch Aug 9, 2026
7af4067
add example parameter with no upper bound and default infinit value
christianrauch Aug 9, 2026
ae79691
Merge branch 'main' into fix_double_bounds
christophfroehlich Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/test/descriptor_test_gtest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ TEST_F(DescriptorTest, check_integer_descriptors) {
TEST_F(DescriptorTest, check_lower_upper_bounds) {
EXPECT_EQ(descriptors_[2].floating_point_range.at(0).from_value, 0.0001);
EXPECT_EQ(descriptors_[2].floating_point_range.at(0).to_value,
std::numeric_limits<double>::max());
std::numeric_limits<double>::infinity());
}

TEST_F(DescriptorTest, check_lt_eq) {
Expand Down
5 changes: 5 additions & 0 deletions example_python/generate_parameter_module_example/parameters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,11 @@ admittance_controller:
type: int_array_fixed_5
default_value: [3,3,3]
read_only: true
double_no_upper_bound:
type: double
default_value: .inf
validation:
gt_eq<>: 0
Comment on lines +348 to +352

@christianrauch christianrauch Aug 9, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to myself: The change appears in example_python because the C++ parameter file is symlinked to this one.

hover_override:
type: int
default_value: 1
Expand Down
4 changes: 2 additions & 2 deletions ..._parameter_library_py/generate_parameter_library_py/jinja_templates/cpp/declare_parameter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ descriptor.additional_constraints = {{parameter_additional_constraints | valid_s
{%- endfor %}
{%- if range.lower is not none or range.upper is not none %}
descriptor.floating_point_range.resize(1);
descriptor.floating_point_range.at(0).from_value = {{range.lower if range.lower is not none else "std::numeric_limits<double>::lowest()"}};
descriptor.floating_point_range.at(0).to_value = {{range.upper if range.upper is not none else "std::numeric_limits<double>::max()"}};
descriptor.floating_point_range.at(0).from_value = {{range.lower if range.lower is not none else "-std::numeric_limits<double>::infinity()"}};
descriptor.floating_point_range.at(0).to_value = {{range.upper if range.upper is not none else "std::numeric_limits<double>::infinity()"}};
{%- endif %}
{%- elif "INTEGER" in parameter_type %}
{%- set range = namespace(lower=None, upper=None) %}
Expand Down
4 changes: 2 additions & 2 deletions ...er_library_py/generate_parameter_library_py/jinja_templates/cpp/declare_runtime_parameter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ descriptor.additional_constraints = {{parameter_additional_constraints | valid_s
{%- endfor %}
{%- if range.lower is not none or range.upper is not none %}
descriptor.floating_point_range.resize(1);
descriptor.floating_point_range.at(0).from_value = {{range.lower if range.lower is not none else "std::numeric_limits<double>::lowest()"}};
descriptor.floating_point_range.at(0).to_value = {{range.upper if range.upper is not none else "std::numeric_limits<double>::max()"}};
descriptor.floating_point_range.at(0).from_value = {{range.lower if range.lower is not none else "-std::numeric_limits<double>::infinity()"}};
descriptor.floating_point_range.at(0).to_value = {{range.upper if range.upper is not none else "std::numeric_limits<double>::infinity()"}};
{%- endif %}
{%- elif "INTEGER" in parameter_type %}
{%- set range = namespace(lower=None, upper=None) %}
Expand Down