Improve Python custom validator example#365
Open
aryanputta wants to merge 1 commit into
Open
Conversation
christophfroehlich
requested changes
Jun 29, 2026
christophfroehlich
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for improving this.
Please use the same logic as in the c++ example, or adapt both. I try to have the same content in both examples. Can you also leave a review in #361 for that reason please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_parameter_moduleFixes #321.
Validation
python3 -m py_compile example_python/generate_parameter_module_example/custom_validation.pyexample_python/generate_parameter_module_example/parameters.yamland parsed it withast.parsegit diff --checkenv SKIP=ament_copyright pre-commit run --files README.md example_python/generate_parameter_module_example/custom_validation.py example_python/generate_parameter_module_example/parameters.yamlament_copyrightis not installed in my local environment, so I could not run that hook locally. All other touched-file pre-commit hooks passed.