Fix clang-tidy errors#173
Open
aryanputta wants to merge 1 commit into
Open
Conversation
49f44ec to
14e584e
Compare
christophfroehlich
requested changes
Jun 29, 2026
christophfroehlich
left a comment
Collaborator
There was a problem hiding this comment.
Duplicate of #171
Can you please check the existing PR, and comment there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#pragma oncewith include guards in the public RSL headers flagged by clang-tidyQueue's simple mutex guards tostd::scoped_lockreadability-math-missing-parenthesesmodernize-use-constraintsandmodernize-use-std-numberssuggestions with commentsFixes #168.
Validation
pre-commit run --files include/rsl/algorithm.hpp include/rsl/monad.hpp include/rsl/no_discard.hpp include/rsl/overload.hpp include/rsl/parameter_validators.hpp include/rsl/queue.hpp include/rsl/random.hpp include/rsl/static_string.hpp include/rsl/static_vector.hpp include/rsl/strong_type.hpp include/rsl/try.hpp src/random.cpp tests/queue.cppgit diff --checkc++ -std=c++17 -Iinclude -fsyntax-only -x c++-header include/rsl/queue.hppc++ -std=c++17 -Iinclude -fsyntax-only -x c++-header include/rsl/algorithm.hppc++ -std=c++17 -Iinclude -fsyntax-only -x c++-header include/rsl/no_discard.hppI could not run the full CMake/ROS test matrix locally on macOS: the repo preset assumes Linux
lld, and a local CMake configure without that preset stops on missing ROS/Eigen dependencies. The GitHub Actions matrix should cover the full ROS/clang-tidy path.