One thing to keep note, I have created a constants file in my branch with a Constants namespace (mainly to keep things separate ad as much stuff out of the global namespace as possible).
I don't know if we will want to keep it that way, but I can push the change if necessary to prevent confusion in the future.
A random line that will be affected if we decide to put the constants in a namespace (more are in the file):
https://github.com/PhyXTGears-programming/2023-RobotCode/blob/38a3d5bb7d432939cf8e0dc766b7ccd1ea0dde10/src/main/cpp/subsystems/arm/arm.cpp#L8_L9
One thing to keep note, I have created a constants file in my branch with a
Constantsnamespace (mainly to keep things separate ad as much stuff out of the global namespace as possible).I don't know if we will want to keep it that way, but I can push the change if necessary to prevent confusion in the future.
A random line that will be affected if we decide to put the constants in a namespace (more are in the file):
https://github.com/PhyXTGears-programming/2023-RobotCode/blob/38a3d5bb7d432939cf8e0dc766b7ccd1ea0dde10/src/main/cpp/subsystems/arm/arm.cpp#L8_L9