Skip to content

New script actions for enabling & disabling AI triggers - #565

Open
FS-21 wants to merge 50 commits into
Phobos-developers:developfrom
FS-21:feature/ai-trigger-manipulation-actions
Open

New script actions for enabling & disabling AI triggers#565
FS-21 wants to merge 50 commits into
Phobos-developers:developfrom
FS-21:feature/ai-trigger-manipulation-actions

Conversation

@FS-21

@FS-21 FS-21 commented Mar 31, 2022 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Ai trigger manipulation. More information in the documentation

Summary by CodeRabbit

  • New Features

    • Introduced new script actions for AI trigger management, including setting indices and enabling/disabling triggers based on various criteria.
    • Enhanced functionality for managing AI triggers in game scenarios.
    • Added automatic deletion logic for passengers in vehicles.

  • Bug Fixes

    • Resolved issues in the MC deployer functionality.

  • Documentation

    • Updated AI scripting and mapping guidance.
    • Documented new and enhanced logics affecting game mechanics.
    • Added contributions to the help documentation.

  • Refactor

    • Improved data handling and processing of AI triggers in the game's rules system.

@FS-21

FS-21 commented Mar 31, 2022

Copy link
Copy Markdown
Contributor Author

These triggers were tested by me with and currently I haven't found any new bug.

@github-actions

github-actions Bot commented Mar 31, 2022 •
edited
Loading

Copy link
Copy Markdown

Nightly build for this pull request:

@FS-21

FS-21 commented Apr 4, 2022

Copy link
Copy Markdown
Contributor Author

For testing this PR:
Before it gets merged into develop you can test if this works reading the Ai triggers information in the Debug.log file after each ObjectInfo execution.

Metadorius and others added 3 commits May 11, 2022 19:55
@Metadorius
Update GH Actions workflows
0fa5476 
- Split non-PR and main branch nightly build PRs
- Use PR HEAD instead of merge commit
@FS-21
Merge remote-tracking branch 'origin/develop' into feature/ai-trigger…
8d300a5 
…-manipulation-actions
@FS-21
Fix name due to YRpp change
5299dff
FS-21 added 6 commits October 17, 2022 19:45
@FS-21
Point to latest YRpp
2500eb9
@FS-21
Merge remote-tracking branch 'origin/develop' into feature/ai-trigger…
9a77959 
…-manipulation-actions
@FS-21
Point changelog to v0.3.1 and not v0.3
e9c7793
@FS-21
Actions renumeration
41825d9 
Changed action numbers:

SetSideIdxForManagingTriggers = 127 -> 16005,
SetHouseIdxForManagingTriggers = 128 -> 16006,
ManageAllAITriggers = 129 -> 16007,
EnableTriggersFromList = 130 -> 16008,
DisableTriggersFromList = 131 -> 16009,
DisableTriggersWithObjects = 133 -> 16010,
EnableTriggersWithObjects = 132 -> 16011,
@FS-21
Added lost documentation from older merges
531e771 
And updated the action ranges of these new actions
@FS-21
small change in docs
aaa7f0b
@FS-21
Rewrote HouseExt::GetHouseIndex(...) with the requested changes.
474a070 
Applied all the feedback to these AITrigger manipulation functions. I also tweaked some "return" that didn't explain "why" and avoided an infinite loop.

Tweaked ScriptExt::SetCloseEnoughDistance() with a small change not related to this PR (is too small for a PR and isn't a bug).
@FS-21

FS-21 commented Jul 15, 2024

Copy link
Copy Markdown
Contributor Author

I rewrote HouseExt::GetHouseIndex(...) with the requested changes.
Applied all the feedback to these AITrigger manipulation functions. I also tweaked some "return" that didn't explain "why" and avoided an infinite loop.

I also tweaked ScriptExt::SetCloseEnoughDistance() with a small change not related to this PR (is too small for a PR and isn't a bug).

I still have to touch that documentation mistake :-/

@FS-21

FS-21 commented Jul 15, 2024

Copy link
Copy Markdown
Contributor Author

I didn't notice that 16005 has been occupied by another script Action so I'll move the number to the first emply.

@FS-21 FS-21 changed the title New actions 127 to 133 for enabling & disabling AI triggers New script actions for enabling & disabling AI triggers Aug 29, 2024
@FS-21

FS-21 commented Aug 29, 2024

Copy link
Copy Markdown
Contributor Author

Added the FA2 documentation, if is something missing tell me something :-D

@Starkku
Starkku force-pushed the develop branch 2 times, most recently from b429215 to 280b1c8 Compare June 29, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Starkku Starkku Starkku requested changes
@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Requested changes must be addressed to merge this pull request.

Assignees

@Starkku Starkku

Labels

Needs improvement Needs testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FS-21 @Starkku @Belonit @Metadorius