Detonate Ivan Bombs placed by the attacker using custom warhead.

[dh381-1]

What kind of change is this?

• New feature, vanilla bugfix or enhancement of a released feature - changelog, docs and credits entries are needed.
• Improvement to a new (unreleased) feature - docs and credits entries are needed; no changelog entry (Skip Changelog).
• Bugfix to a new (unreleased) feature - credits entry is needed; no changelog or docs entries (Skip Changelog, Skip Docs).
• Bugfix to an old (released) feature - changelog and credits entries are needed; no docs entry (Skip Docs).
• Completely minor change (e.g. a typo fix) - no entries are needed (Skip Changelog, Skip Docs, Skip Credits).

Description

• Now you can detonate planted Ivan bombs using custom warhead. The bomb attached to the targeted unit will explode immediately, provided that it was planted by the attacker.

In rulesmd.ini:

[SOMEWARHEAD]               ; WarheadType
IvanBomb.Detonate=true     ; boolean

[phoboscn-bot]

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户：
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息：

https://www.phoboscn.top/t/topic/725/14

[phoboscn-bot]

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户：
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息：

https://www.phoboscn.top/t/topic/739/1

[NetsuNegi]

pThis should be TechnoClass*. Besides, register esi has been popped here, I think you should not use it.
pThis 应该是 TechnoClass*。另外，ESI寄存器在此处已被弹出，我认为你不该用它。

[dh381-1]

After changing the hook location,register esi can be used
换了一个hook位置，ESI寄存器现在就可以用了

[github-actions]

Nightly build for this pull request:

• compiled-dll-36c81132ef4e2ccaf852fa9fa6428c051ce049f9.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[DeathFishAtEase]

Suggested change

	IvanBomb.Detonate=true ; Enable bomb detonation (true/false), default: false.
	IvanBomb.Detonate=false ; boolean

If there is a fixed default value, it should be placed as the value on the right side of the equals sign; only the value type should be written after the semicolon.

[NetsuNegi]

what's this ?

[NetsuNegi]

Suggested change

	if(auto pSourceExt = TechnoExt::TryFetch(pSource))
	if(auto pSourceExt = TechnoExt::Fetch(pSource))

No need use TryFetch here, you had checked pSource before.
这里不需要使用 TryFetch，你在前面已经检查过 pSource 了。

[NetsuNegi]

Other codes looking good

[Coronia]

I think this doesn't have to be restricted to the owner's bomb. It would also be useful if another unit could detonate it. Something like this:

IvanBomb.Detonate.InvokerOnly -> whether it can only affect your own bomb or not
IvanBomb.Detonate.AffectsType -> TechnoTypes in this list can have their ivan bomb detonated by this warhead. Use empty list for all types

[Coronia]

no need to use TryFetch here since it has already been checked above