New Feature: Support Convert to another type.

[frg2089]

Summary

Refactored the underlying type conversion system (ConvertToType / ConvertToTypeEx) to support cross-type conversion between all TechnoType classes except AircraftType. Added UndeploysInto.ConvertTo as a new conversion trigger on BuildingType.

Changes

Core: rewritten conversion logic

• ConvertToType and new ConvertToTypeEx now handle cross-type conversion via creating a new object + destroying the old one, supporting InfantryType, UnitType, and BuildingType.
• AircraftType is only supported for same-type conversion (in-place type pointer update).
• Deferred conversion via PendingConvertTechnoType processed in OnEarlyUpdate — used when the source unit needs to finish its current animation frame before being destroyed.

This improvement applies to all existing conversion paths (Convert.Deploy, Convert.Undeploy, Convert.HumanToComputer, Convert.ComputerToHuman, etc.).

New feature: UndeploysInto.ConvertTo

• BuildingType tag UndeploysInto.ConvertTo specifies a target TechnoType.
• After UndeploysInto creates the vehicle, it is converted to the target type on the next frame.
• The resulting unit inherits the vehicle's move order, destination, and selection state.
• Mind control, shields, invulnerability, and attached effects are transferred.

Refactor

• Moved TransferMindControlOnDeploy from Hooks.DeploysInto.cpp into TechnoExt as a reusable static method.

Selection preservation

• Both deploy (infantry → building) and undeploy convert (vehicle → other) now preserve the original unit's selection state on the new unit.

Documentation

Updated New-or-Enhanced-Logics.md with documentation for UndeploysInto.ConvertTo, the expanded type support in Convert.Deploy / Convert.Undeploy, and a warning that cross-type conversion creates a new object and destroys the old one.

Files Changed

File	Change
src/Ext/Techno/Body.cpp	ConvertToTypeEx cross-type conversion, ConvertToType same-type fallback, property transfer
src/Ext/Techno/Body.h	PendingConvertTechnoType, static method declarations
src/Ext/Techno/Body.Update.cpp	Deferred conversion processing
src/Ext/Unit/Hooks.DeploysInto.cpp	Delegate to TechnoExt, add UndeploysInto.ConvertTo hook
src/Ext/BuildingType/Body.h/.cpp	UndeploysInto.ConvertTo tag
docs/New-or-Enhanced-Logics.md	Documentation

[github-actions]

Nightly build for this pull request:

• compiled-dll-40f9915dcee953be23f8faeb4b8a56854da02d73.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[TaranDahl]

I see no other issues.

[frg2089]

喵？

[TaranDahl]

喵？

Since this is your first PR submission, your code will need reviews from more maintainers before it can be merged. This is the rule of Phobos.

[frg2089]

Since this is your first PR submission, your code will need reviews from more maintainers before it can be merged. This is the rule of Phobos.

OK, I will stop resolving the conflict before there are further results.

[Copilot]

Pull request overview

This pull request refactors Phobos’ TechnoType conversion pipeline to support cross-category conversions (object replacement) across Infantry/Unit/Building types, adds a new BuildingType INI trigger (UndeploysInto.ConvertTo) to convert the undeployed unit on the next frame, and updates documentation/changelog/credits accordingly.

Changes:

• Added cross-category conversion via TechnoExt::ConvertToTypeEx (create new object + destroy old), with deferred conversion support (PendingConvertTechnoType) processed in TechnoExt::OnEarlyUpdate.
• Centralized status transfer during deploy/undeploy (mind control, shields, invulnerability, attached effects, multipliers, etc.) via TechnoExt::SyncStatus.
• Added deploy feedback improvements and documented the new conversion behaviors (including zh_CN locale updates and credits/changelog entries).

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/Misc/Hooks.BugFixes.cpp	Switches deploy-to-fire checks to TechnoExt::CanDeployIntoBuilding.
src/Ext/Unit/Hooks.DeploysInto.cpp	Uses TechnoExt::SyncStatus, adds UndeploysInto.ConvertTo deferral, adds deploy action hook, adjusts deploy placement/desync logic.
src/Ext/Unit/Hooks.DeployFire.cpp	Adds NoDeploy feedback (EVA) when Convert.Deploy targets a building without sufficient space.
src/Ext/Unit/Body.h	Removes UnitExt deployer/static deploy checks now moved into TechnoExt.
src/Ext/Unit/Body.cpp	Removes UnitExt::Deployer and UnitExt::CanDeployIntoBuilding implementation.
src/Ext/Techno/Body.Update.cpp	Processes deferred conversions (PendingConvertTechnoType) during early update.
src/Ext/Techno/Body.h	Adds PendingConvertTechnoType, Deployer, and new conversion/status-transfer method declarations.
src/Ext/Techno/Body.cpp	Implements SyncStatus, moves deploy-related helpers into TechnoExt, and adds ConvertToTypeEx for cross-category conversions.
src/Ext/BuildingType/Body.h	Adds UndeploysInto_ConvertTo storage and declares a helper for deploy cell computation.
src/Ext/BuildingType/Body.cpp	Implements GetDeployBuildingTopLeftCell, reads/serializes UndeploysInto.ConvertTo.
docs/Whats-New.md	Adds changelog entries for cross-category conversion and related improvements.
docs/New-or-Enhanced-Logics.md	Documents UndeploysInto.ConvertTo.
docs/Fixed-or-Improved-Logics.md	Updates “fixed/improved” notes for conversion behavior and feedback.
docs/locale/zh_CN/LC_MESSAGES/Whats-New.po	Adds zh_CN translations for new changelog bullets.
docs/locale/zh_CN/LC_MESSAGES/New-or-Enhanced-Logics.po	Adds zh_CN translations for UndeploysInto.ConvertTo docs.
docs/locale/zh_CN/LC_MESSAGES/Fixed-or-Improved-Logics.po	Updates zh_CN translations to match new conversion/feedback entries.
docs/locale/zh_CN/LC_MESSAGES/CREDITS.po	Adds zh_CN credits entries for the contributor.
CREDITS.md	Adds credits entries for the new conversion features and preservation behaviors.

Suppressed comments (3)

src/Ext/Techno/Body.cpp:526

• ConvertToTypeEx calls SyncStatus (which can transfer mind control, shields, attached effects, etc.) before ForceCreate. If ForceCreate fails, the source unit's state may already have been mutated (e.g., mind control freed), leaving it in an inconsistent state.

		SyncStatus(pThis, pBuilding);

		pBuilding->QueueMission(Mission::Construction, false);
		pBuilding->NextMission();

src/Ext/Techno/Body.cpp:576

• ConvertToTypeEx calls SyncStatus before attempting Unlimbo the new unit. If Unlimbo fails, the rollback path re-unlimbos the old unit but does not restore any state already transferred (mind control, attached effects, etc.). Move status transfer until after the new unit has been successfully placed.

		if (auto const pUnit = static_cast<FootClass*>(pToType->CreateObject(pHouse)))
		{
			SyncStatus(pThis, pUnit);

			// Remove old techno from map
			pThis->Limbo();

src/Ext/Techno/Body.cpp:568

• PR description says cross-category conversion should not support AircraftType (only same-type in-place conversion). ConvertToTypeEx currently includes AbstractType::AircraftType in the cross-type object-replacement path, which contradicts that behavior.

	case AbstractType::InfantryType:
	case AbstractType::UnitType:
	case AbstractType::AircraftType:

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.