Skip to content

[Vanilla Enhancement] Improve occupants firing logic#2220

Draft
NetsuNegi wants to merge 8 commits into
Phobos-developers:developfrom
NetsuNegi:branch/improve_occupy_fire
Draft

[Vanilla Enhancement] Improve occupants firing logic#2220
NetsuNegi wants to merge 8 commits into
Phobos-developers:developfrom
NetsuNegi:branch/improve_occupy_fire

Conversation

@NetsuNegi
Copy link
Copy Markdown
Contributor

In rulesmd.ini:

[CombatDamage]
FixOccupyFire=false         ; boolean
UseGlobalOccupyRange=true   ; boolean

@NetsuNegi NetsuNegi added Needs testing ⚙️T1 T1 maintainer review is sufficient ❓Unhardcoding / Customization Make something more tweakable labels May 21, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@phoboscn-bot
Copy link
Copy Markdown

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户:
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息:

https://www.phoboscn.top/t/topic/502/1

@Metadorius
Copy link
Copy Markdown
Member

the docs say nothing, did you forget to write them?

@DeathFishAtEase
Copy link
Copy Markdown
Collaborator

DeathFishAtEase commented May 21, 2026

Document, but draft.jpg

Additionally, FixOccupyFire is actually used to enable a new garrison firing system, but this INI name sounds like it fixes some kind of bug.

@Metadorius
Copy link
Copy Markdown
Member

ah, good old "proper garrisons with individual ranges/verses". was the second thing I tried to do when we were starting Phobos, and I concluded it wasn't worth it

I don't really mind, but it's a pile of hacks on top of vanilla pile of hacks. wouldn't it be better to further extend OpenTopped?

In `rulesmd.ini`:
```ini
[CombatDamage]
FixOccupyFire=false ; boolean
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExtendedOccupyFire

@Metadorius
Copy link
Copy Markdown
Member

for reference: #1879

@NetsuNegi NetsuNegi marked this pull request as draft May 22, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs testing ⚙️T1 T1 maintainer review is sufficient ❓Unhardcoding / Customization Make something more tweakable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants