Cloak Enchancement

[NetsuNegi]

• When unit start cloak or stop cloaking, an animation can play on his location
  • You can also set whether cloak units kick out parasites

In rulesmd.ini:

[General]
Cloak.KickOutParasite=true    ; boolean

[AudioVisual]
CloakAnims=                   ; List of Animation
DecloakAnims=                 ; List of Animation

[SOMETECHNO]
CloakAnims=                   ; List of Animation, default to [AudioVisual] -> CloakAnims
DecloakAnims=                 ; List of Animation, default to [AudioVisual] -> DecloakAnims
Cloak.KickOutParasite=        ; boolean, default to [General] -> Cloak.KickOutParasite

[github-actions]

Nightly build for this pull request:

• compiled-dll-48d9e5f0b27fee36feada974ff08e21554464689.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[NetsuNegi]

did someone test this ?

[mevitar]

Animations seem to work fine, for inherent and warhead-induced cloak. Haven't tried parasites.

[MortonPL]

Please add a credits, documentation and "What's New" entry. I've already edited the description to match the current INI documentation standard.

Left a few comments and one question about a peculiar pointer access.

[NetsuNegi]

Please add a credits, documentation and "What's New" entry. I've already edited the description to match the current INI documentation standard.

Left a few comments and one question about a peculiar pointer access.

I'll fix docs tomorrow

[mevitar]

A minor nitpick: in the documentation, the comments about tag entries aren't perfectly aligned like they are for other tags.

[NetsuNegi]

A minor nitpick: in the documentation, the comments about tag entries aren't perfectly aligned like they are for other tags.

fixed

[mevitar]

fixed

Not for the english version, though. :P

[mevitar]

Maybe my browser simply didn't update its cache last time, but now it looks properly even for the english version.

[mevitar]

Does something here needs testing or is it waiting for fixes?

[NetsuNegi]

Does something here needs testing or is it waiting for fixes?

Probably not, it just seems like it's just forgotten.

[NetsuNegi]

Looks like OK to merge, is something need improve or fix?

[mevitar]

Everything seems to be working fine.

[mevitar]

Documentation needs more info, specifically, the tags applicable to TechnoTypes, what value they default to.

[SOMETECHNO]
CloakAnim=                   ; Animation
DecloakAnim=                 ; Animation
Cloak.KickOutParasite=       ; boolean

should be:

[SOMETECHNO]
CloakAnim=                   ; Animation, defaults to [AudioVisual]->CloakAnim
DecloakAnim=                 ; Animation, defaults to [AudioVisual]->DecloakAnim
Cloak.KickOutParasite=       ; boolean, defaults to [CombatDamage]->Cloak.KickOutParasite