Fix nullable enum properties crashing on insertion - #111
Open
Eisfunke wants to merge 4 commits into
Open
Conversation
This makes it possible to use multiple containers with different settings using the same base DBMS
… type Previously, null-checks were only performed for nullable *reference* types. Nullable types that have a converter to a value type, like enums, lost their nullability during conversion, leading to runtime-crashes.
Contributor
Author
|
Hey! My colleague @davidmehren and I were able to fix this problem. It looks like previously, null-checks were only performed for nullable reference types. Nullable types that have a converter to a value type, like enums, lost their nullability during conversion, leading to runtime-crashes. Our guess is that this wasn't noticed before since nullable value types that have a conversion are pretty much only nullable enums in everyday usage, because the more common types like So this MR now adds a test and a fix for this and should be mergeable now. (note that I added a few files to the .gitignore for my own setup, if you don't want those flying around there, just say so and I'll take that out) |
Eisfunke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #110 for details