test(ci): give run_lint_gates a compile tier mirroring the warnings + check jobs

[proggeramlug]

Why

scripts/run_lint_gates.sh derived its command list from test.yml's lint
job only. The compile-level gates live in two separate jobs:

• warnings — cargo check --workspace --all-targets under -D warnings
• check — cargo clippy --workspace

So the script could report all 48 gates passed while main was red.

That is not hypothetical. #8333 rewrote two assertions in
crates/perry-codegen/tests/typed_feedback.rs and left the block_body helper
with no callers. main went red on warnings:

error: function `block_body` is never used
error: could not compile `perry-codegen` (test "typed_feedback") due to 1 previous error

It was merged, and every PR audited afterwards got a green "48 gates" report
from this script while the repo was broken. #8339 fixed the warning; this fixes
the blind spot that let it through. A tier you do not run is a tier that did not
pass — which is the argument this script exists to make.

What

• Add a compile tier running both jobs' commands.
• Derive the host-compatible package scope from
  scripts/workspace_architecture.py --print-excluded-scope host-compatible,
  exactly as both CI jobs do, so the anti-drift property is preserved rather
  than hardcoded (18 exclude args at time of writing).
• SKIP_COMPILE_GATES=1 keeps a fast path for iteration. A skipped run prints
  (compile tier SKIPPED) in the summary, so it cannot be mistaken for a full
  one.

Validation

• Clean main (with fix(codegen): silence a pre-existing dead_code warning on a test helper #8339): run_lint_gates: all 50 gates passed
• Sabotage — plant an unused fn in a test target: run_lint_gates: 2 of 50 FAILED,
  naming warnings: cargo check --workspace --all-targets. Run against main
  before fix(codegen): silence a pre-existing dead_code warning on a test helper #8339 it independently reported the real block_body error, i.e. it
  would have caught fix(dyn_eval): root global this before env_new_root allocates; fix two pre-existing codegen tests #8333.
• SKIP_COMPILE_GATES=1 → all 48 gates passed (compile tier SKIPPED)
• bash -n scripts/run_lint_gates.sh

Summary by CodeRabbit

• New Features

  • Added compile validation to lint-gate checks, including warning-enforced checks and Clippy analysis.
  • Added architecture-aware package scoping for validation.
  • Added an option to skip compile checks with a clear skipped status.

• Documentation

  • Updated validation guidance and changelog details to describe the new compile tier and reporting.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: eb2315b5-6699-4b7d-9d8e-375a004911ac

📥 Commits

Reviewing files that changed from the base of the PR and between 2dda0e5 and bb9ff84.

📒 Files selected for processing (2)

• changelog.d/8344-run-lint-gates-compile-tier.md
• scripts/run_lint_gates.sh

---

📝 Walkthrough

Walkthrough

The lint gate script now adds optional compile checks. It derives workspace exclusions, runs warning-enforced cargo check and cargo clippy, captures failures, and reports executed or skipped compile gates. A changelog entry documents the behavior.

Changes

Lint gate execution

Layer / File(s)	Summary
Compile tier and result reporting scripts/run_lint_gates.sh, changelog.d/8344-run-lint-gates-compile-tier.md	The script documents and runs the optional compile tier with architecture-derived package exclusions. It captures cargo check and cargo clippy failures, updates totals, and reports skipped status. The changelog records these changes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• PerryTS/perry#6793: Modifies local CI validation scripts to organize compile-dependent lint and check gates with failure reporting.

Suggested labels: tooling

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/run-lint-gates-compile-tier

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}