fix(windows): bundle the LLVM runtime with Perry - #8018
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughWindows release and npm packaging now validate and bundle ChangesWindows LLVM packaging
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: ⚪ Minimal · up to The change bundles the required LLVM runtime with Windows builds and validates release and npm staging behavior; no actionable merge-blocking risk remains beyond normal checks. Sequence Diagram(s)sequenceDiagram
participant ReleaseWorkflow as release-packages.yml
participant LLVMReadobj as llvm-readobj.exe
participant ReleaseStaging as Windows release staging
ReleaseWorkflow->>ReleaseWorkflow: Check perry.exe, llvm-readobj.exe, and LLVM-C.dll
ReleaseWorkflow->>LLVMReadobj: Inspect perry.exe imports
LLVMReadobj-->>ReleaseWorkflow: Report LLVM-C.dll import
ReleaseWorkflow->>ReleaseStaging: Stage perry.exe and LLVM-C.dll
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
LLVM-C.dllbesideperry.exein the Windows release zip@perryts/perry-win32-x64gc-native-rootsstatus after fix: restore CI portability and GC correctness #8017's dynamic-link fixperry.exeon currentmainlinks successfully after #8017, but importsLLVM-C.dll. The release workflow did not package that DLL, so an extracted release exited with Windows loader error0xC0000135unless LLVM happened to be installed globally. This completes the #7985 fix without restoring the incompatible static/MT+ rpmalloc link.Validation
cargo build --profile perry-dev -p perryon Windows with the official LLVM 22.1.8 archiveLLVM-C.dllandVCRUNTIME140.dllperry.exe+LLVM-C.dllbundle runs withC:\llvm\binremoved fromPATHtests/test_stage_npm_windows_llvm.shpasses its copy and missing-DLL refusal armsgit diff --checkNo version bump.
Closes #7985
Summary by CodeRabbit
Bug Fixes
LLVM-C.dllalongsideperry.exe.Tests