test(http2): expand Node parity coverage - #6866
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThe HTTP/2 parity suite expands to 59 deterministic fixtures covering Node API surfaces, settings helpers, sessions, streams, plaintext exchanges, validation behavior, and cross-runtime evidence. The baseline changes from 8/9 to 32/59. ChangesHTTP/2 parity suite
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test-parity/node-suite/http2/compat/request-properties.ts`:
- Around line 25-28: Add an error listener to the client request stream created
in the request fixture, routing the emitted error to the existing promise
rejection path before resuming and ending the request. Keep the current
successful completion flow through received unchanged.
In `@test-parity/node-suite/http2/headers/invalid-request-pseudoheader.ts`:
- Around line 12-20: Add a no-op error listener to each accepted request stream
before request.destroy() in the loop, and apply the same change to the
request-option-validation fixture’s accepted streams. Preserve the existing
logging and destruction behavior.
In `@test-parity/node-suite/http2/README.md`:
- Line 56: Update the sentence describing the focused suite so the compound
modifier reads “57-fixture-focused suite,” adding the missing hyphen between
“fixture” and “focused.”
In `@test-parity/node-suite/http2/session/request-option-validation.ts`:
- Around line 20-29: In the accepted-request branch of the request-option
validation loop, attach a one-shot request error listener before calling
request.destroy() to safely consume any destruction error. Keep the existing
logging and cleanup behavior unchanged.
In `@test-parity/node-suite/http2/settings/numeric-boundaries.ts`:
- Around line 16-17: Update the loop over cases in the numeric-boundaries
fixture to log or compare the actual serialized Buffer returned by
getPackedSettings, using a stable hex or base64 representation instead of only
its length. Match the representation and assertion pattern used by the other
packed-settings fixtures so boundary encoding differences are observable.
In `@test-parity/node-suite/http2/settings/packed-empty.ts`:
- Around line 3-4: Update the output in the packed-settings parity test to log
the serialized bytes themselves as hex strings rather than only their lengths.
Apply this to both getPackedSettings() calls, preserving the distinction between
the missing and empty inputs so their actual serialized contents can be
compared.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 49785c56-8167-48ce-9642-28dfc159ce7a
📒 Files selected for processing (68)
test-parity/node-suite/http2/README.mdtest-parity/node-suite/http2/compat/request-properties.tstest-parity/node-suite/http2/connect/invalid-authority.tstest-parity/node-suite/http2/connect/listener-overload.tstest-parity/node-suite/http2/connect/unsupported-protocol.tstest-parity/node-suite/http2/constants/header-aliases.tstest-parity/node-suite/http2/constants/representative-values.tstest-parity/node-suite/http2/exports/compat-descriptors.tstest-parity/node-suite/http2/exports/exact-module-keys.tstest-parity/node-suite/http2/exports/function-metadata.tstest-parity/node-suite/http2/exports/performServerHandshake.tstest-parity/node-suite/http2/exports/request-class.tstest-parity/node-suite/http2/exports/response-class.tstest-parity/node-suite/http2/exports/response-receiver-validation.tstest-parity/node-suite/http2/exports/server-client-surface.tstest-parity/node-suite/http2/headers/invalid-request-pseudoheader.tstest-parity/node-suite/http2/headers/sensitive-symbol.tstest-parity/node-suite/http2/module-exports.tstest-parity/node-suite/http2/plaintext/loopback-streams.tstest-parity/node-suite/http2/plaintext/multiplex.tstest-parity/node-suite/http2/plaintext/request-body.tstest-parity/node-suite/http2/plaintext/request-pseudoheaders.tstest-parity/node-suite/http2/plaintext/response-body.tstest-parity/node-suite/http2/plaintext/response-headers.tstest-parity/node-suite/http2/server/create-overloads.tstest-parity/node-suite/http2/server/empty-secure-options.tstest-parity/node-suite/http2/server/inheritance.tstest-parity/node-suite/http2/server/invalid-options.tstest-parity/node-suite/http2/server/invalid-settings-option.tstest-parity/node-suite/http2/server/listen-address.tstest-parity/node-suite/http2/server/node-prefix.tstest-parity/node-suite/http2/session/aborted-request-signal.tstest-parity/node-suite/http2/session/class-names.tstest-parity/node-suite/http2/session/client-close-callback.tstest-parity/node-suite/http2/session/client-connect-state.tstest-parity/node-suite/http2/session/client-destroy-state.tstest-parity/node-suite/http2/session/controls.tstest-parity/node-suite/http2/session/goaway-opaque-data.tstest-parity/node-suite/http2/session/method-surface.tstest-parity/node-suite/http2/session/ping-echo.tstest-parity/node-suite/http2/session/ref-unref.tstest-parity/node-suite/http2/session/request-option-validation.tstest-parity/node-suite/http2/session/sequential-session-cleanup.tstest-parity/node-suite/http2/session/settings-callback.tstest-parity/node-suite/http2/session/settings-shape.tstest-parity/node-suite/http2/settings/default-freshness.tstest-parity/node-suite/http2/settings/default-shape.tstest-parity/node-suite/http2/settings/invalid-boolean-values.tstest-parity/node-suite/http2/settings/invalid-numeric-values.tstest-parity/node-suite/http2/settings/numeric-boundaries.tstest-parity/node-suite/http2/settings/packed-custom.tstest-parity/node-suite/http2/settings/packed-defaults.tstest-parity/node-suite/http2/settings/packed-empty.tstest-parity/node-suite/http2/settings/packed-header-alias.tstest-parity/node-suite/http2/settings/packed-order.tstest-parity/node-suite/http2/settings/packed-unknown-key.tstest-parity/node-suite/http2/settings/settings-helpers.tstest-parity/node-suite/http2/settings/unpacked-aliases.tstest-parity/node-suite/http2/settings/unpacked-custom.tstest-parity/node-suite/http2/settings/unpacked-invalid-length.tstest-parity/node-suite/http2/settings/unpacked-invalid-type.tstest-parity/node-suite/http2/settings/unpacked-typed-array.tstest-parity/node-suite/http2/settings/unpacked-validation.tstest-parity/node-suite/http2/stream/close-validation.tstest-parity/node-suite/http2/stream/initial-state.tstest-parity/node-suite/http2/stream/sent-headers.tstest-parity/node-suite/http2/stream/trailer-surface.tstest-parity/node_suite_baseline.json
💤 Files with no reviewable changes (7)
- test-parity/node-suite/http2/exports/server-client-surface.ts
- test-parity/node-suite/http2/server/empty-secure-options.ts
- test-parity/node-suite/http2/session/controls.ts
- test-parity/node-suite/http2/settings/settings-helpers.ts
- test-parity/node-suite/http2/module-exports.ts
- test-parity/node-suite/http2/server/node-prefix.ts
- test-parity/node-suite/http2/plaintext/loopback-streams.ts
Summary
Expand the granular
node:http2parity suite from 9 to 59 deterministic fixtures, using Node.js 26.5.0 as the oracle and Deno and Bun as comparison runtimes.Changes
8/9to32/59.Related issue
n/a
Test plan
perry,perry-runtime,perry-stdlib, and their static wrappers in release mode.deno fmt --check test-parity/node-suite/http2jq empty test-parity/node_suite_baseline.jsongit diff --checkScreenshots / output
Checklist
Summary by CodeRabbit