Skip to content

[codex] honor sync exec stdio result shape#4304

Draft
andrewtdiz wants to merge 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-child-process-sync-stdio
Draft

[codex] honor sync exec stdio result shape#4304
andrewtdiz wants to merge 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-child-process-sync-stdio

Conversation

@andrewtdiz
Copy link
Copy Markdown
Contributor

Summary

  • Read explicit stdio options for execSync() and execFileSync() sync execution.
  • Return null for non-piped stdout and preserve null stdout/stderr/output slots on thrown sync errors.
  • Add a parity fixture for ignored/inherited sync stdio and mixed captured/null error output.

Validation

  • npm exec --yes --package=node@26 -- node --experimental-strip-types test-parity/node-suite/child_process/sync/sync-stdio.ts
  • npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module child_process --filter sync-stdio'
  • npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module child_process' (18 pass, 0 fail, 0 compile fail)
  • cargo fmt --all -- --check
  • git diff --check
  • ./scripts/check_file_size.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant