Skip to content

[codex] honor spawnSync stdio result shape#4301

Draft
andrewtdiz wants to merge 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-child-process-spawnsync-stdio
Draft

[codex] honor spawnSync stdio result shape#4301
andrewtdiz wants to merge 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-child-process-spawnsync-stdio

Conversation

@andrewtdiz
Copy link
Copy Markdown
Contributor

Summary

  • Teach spawnSync() to read the existing child_process stdio option subset for sync execution.
  • Return null for stdout, stderr, and output slots when stdout/stderr are ignore or inherit instead of boxing empty captures.
  • Add a Node parity fixture for default pipe, string stdio, and mixed array stdio result shapes.

Validation

  • npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module child_process --filter spawn-sync-stdio'
  • npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module child_process' (18 pass, 0 fail, 0 compile fail)
  • cargo fmt --all -- --check
  • git diff --check
  • ./scripts/check_file_size.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant