[codex] honor child_process uid gid options#4298
Draft
andrewtdiz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uid/gidacross spawn, spawnSync, execFileSync, and fork when running as rootuidandgidoptions through the shared child_process command setupgidbeforeuidon Unix so dropped-privilege children observe the supplied identitiesRoot Cause
Perry parsed common child_process options such as
cwdandenv, but ignoreduidandgid. Node applies these IDs before exec, so root-launched children should observe the supplied IDs viaprocess.getuid()andprocess.getgid().Validation
npm exec --yes --package=node@26 -- node --experimental-strip-types test-parity/node-suite/child_process/async/uid-gid.tsNode.js: spawn uid gid: 65534:65534andPerry: spawn uid gid: 0:0npm exec --yes --package=node@26 -- bash -lc "./run_parity_tests.sh --suite node-suite --module child_process --filter uid-gid"npm exec --yes --package=node@26 -- bash -lc "./run_parity_tests.sh --suite node-suite --module child_process"cargo fmt --all -- --checkgit diff --check./scripts/check_file_size.shCovers the
uid/gidoption slice of #2555.