[codex] unskip passing zlib inventory parity#4296
Draft
andrewtdiz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Behavior cluster summary
This removes the stale
test_parity_zlibentry fromtest-parity/known_failures.json. The generated zlib inventory probe and the curatednode-suite/zlibsuite now both pass on currentorigin/mainwith Node 26, so the skip-list should no longer classify zlib inventory as an expected module-inventory failure.Why this is batched
This is intentionally a narrow cleanup because nearby inventory rows are not equally safe to remove: DNS oracle runs exit nonzero in this environment, HTTP/SQLite inventory probes can hang or compile slowly, and the open parity-matrix trend PR #4286 explicitly leaves known-failure row cleanup out of scope. Keeping this to the proven zlib row avoids mixing stale cleanup with unresolved inventory work.
Tests and checks
npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --filter test_parity_zlib'-> 1 pass / 0 fail / 0 compile fail, reporttest-parity/reports/parity_report_20260603_203746.jsonnpm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module zlib'-> 57 pass / 0 fail / 0 compile fail, reporttest-parity/reports/parity_report_20260603_203804.jsonjq empty test-parity/known_failures.jsoncargo fmt --all -- --checkgit diff --check./scripts/check_file_size.shKnown limitations
Only
test_parity_zlibis removed here. Other module-inventory known-failure rows need their own clean, deterministic pass evidence before removal.Non-goals