[codex] honor child_process detached process groups#4295
Draft
andrewtdiz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detached: trueprocess-group behavior acrossspawn,spawnSync, andforkoptions.detached === trueinto shared spawn/spawnSync command constructionRoot Cause
Perry already exposed the documented child_process option surface, but the live and sync command builders ignored
options.detached. On Unix, Node makes a detached child the leader of a new session and process group, so the child shell's process group ID should match its PID. Perry left children in the parent process group.Validation
npm exec --yes --package=node@26 -- node --experimental-strip-types test-parity/node-suite/child_process/async/detached-process-group.tsNode.js: spawn detached same pgid: trueandPerry: spawn detached same pgid: falsenpm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module child_process --filter detached-process-group'(1 pass, 0 compile failures)npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module child_process'(18 pass, 0 compile failures)cargo fmt --all -- --checkgit diff --check./scripts/check_file_size.shCovers the
detachedoption slice of #2555.