[codex] resolve dynamic import literal-union params#4287
Draft
andrewtdiz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1674.
Scope
StringLiteralwhile keeping runtime/codegen treatment equivalent toString.import()andnew Worker()path resolution alongside existing const/local resolution.import(specifier)and template interpolation over a literal-union parameter.Non-goals
"./a.ts" | string.Validation
npm exec --yes --package=node@26 -- node --experimental-strip-types test-parity/node-suite/module/loader/dynamic-import-param-union.tsCARGO_TARGET_DIR=/tmp/perry-param-union-check cargo check -p perry-hir -p perry-codegen -p perry -p perry-runtimeCARGO_TARGET_DIR=/tmp/perry-param-union-check cargo test -p perry-hir dynamic_import -- --nocaptureCARGO_BUILD_JOBS=1 CARGO_TARGET_DIR=/root/perry-worktrees/.build-targets/perry-param-union-build cargo build --release -p perry -p perry-runtime -p perry-stdlibtest-parity/node-suite/module/loader/dynamic-import-param-union.tsPERRY_NO_AUTO_OPTIMIZE=1 CARGO_TARGET_DIR=/root/perry-worktrees/.build-targets/perry-param-union-build npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module module --filter dynamic-import-param-union'PERRY_NO_AUTO_OPTIMIZE=1 CARGO_TARGET_DIR=/root/perry-worktrees/.build-targets/perry-param-union-build npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module module --filter dynamic-import'cargo fmt --all -- --checkgit diff --check./scripts/check_file_size.sh