[codex] retire CI-env parity fixture skips#4285
Draft
andrewtdiz wants to merge 1 commit into
Draft
Conversation
66c92fa to
9d4740c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Summary
This PR retires the stale
ci-envknown-failure entries owned by #1634. The legacy top-level net fixtures already have local companion servers, but readiness polling depended on runnernc; the Ramda-named fixture is now a self-contained mini-reproducer and no longer imports the package.Changes:
wait_for_tcp_porthelper inrun_parity_tests.shthat probes local TCP readiness with Python sockets instead of runnernc;ci-enventries fromtest-parity/known_failures.json.Why this batch
These entries share the same stale CI-environment classification. The net entries are companion-server lifecycle checks, and
test_ramda_sumhas since become a self-contained runtime mini-reproducer rather than an npm-install fixture. Keeping them together closes the #1634 skip-list cleanup without mixing runtime behavior changes.Validation
bash -n run_parity_tests.shjq empty test-parity/known_failures.jsoncargo fmt --all -- --checkgit diff --check./scripts/check_file_size.shnpm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --filter test_issue_422_socket_connect'npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --filter test_net_min'npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --filter test_net_socket'npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --filter test_net_upgrade_tls'npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --filter test_sock_write_map'npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --filter test_ramda_sum'Known limitations
The TLS-upgrade fixture still uses its stored expected-output path because Node exits nonzero for this Perry-specific helper shape; the Perry expected-output comparison passes. Module-inventory and stream/web known-failure entries are unchanged.
Non-goals
No Node runtime behavior, net stdlib behavior, npm package installation, module-inventory skips, or stream/web behavior are changed here.