Skip to content

[codex] retire CI-env parity fixture skips#4285

Draft
andrewtdiz wants to merge 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-ci-net-fixtures
Draft

[codex] retire CI-env parity fixture skips#4285
andrewtdiz wants to merge 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-ci-net-fixtures

Conversation

@andrewtdiz
Copy link
Copy Markdown
Contributor

@andrewtdiz andrewtdiz commented Jun 3, 2026

Linked issues

Summary

This PR retires the stale ci-env known-failure entries owned by #1634. The legacy top-level net fixtures already have local companion servers, but readiness polling depended on runner nc; the Ramda-named fixture is now a self-contained mini-reproducer and no longer imports the package.

Changes:

Why this batch

These entries share the same stale CI-environment classification. The net entries are companion-server lifecycle checks, and test_ramda_sum has since become a self-contained runtime mini-reproducer rather than an npm-install fixture. Keeping them together closes the #1634 skip-list cleanup without mixing runtime behavior changes.

Validation

  • bash -n run_parity_tests.sh
  • jq empty test-parity/known_failures.json
  • cargo fmt --all -- --check
  • git diff --check
  • ./scripts/check_file_size.sh
  • Node v26 focused parity filters, all 1 pass / 0 parity fail / 0 compile fail:
    • npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --filter test_issue_422_socket_connect'
    • npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --filter test_net_min'
    • npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --filter test_net_socket'
    • npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --filter test_net_upgrade_tls'
    • npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --filter test_sock_write_map'
    • npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --filter test_ramda_sum'

Known limitations

The TLS-upgrade fixture still uses its stored expected-output path because Node exits nonzero for this Perry-specific helper shape; the Perry expected-output comparison passes. Module-inventory and stream/web known-failure entries are unchanged.

Non-goals

No Node runtime behavior, net stdlib behavior, npm package installation, module-inventory skips, or stream/web behavior are changed here.

@andrewtdiz andrewtdiz force-pushed the codex/node-compat-ci-net-fixtures branch from 66c92fa to 9d4740c Compare June 3, 2026 18:26
@andrewtdiz andrewtdiz changed the title [codex] harden net fixture parity readiness [codex] retire CI-env parity fixture skips Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parity CI: environment-only failures (server fixtures, npm install, runner-specific)

1 participant