[codex] support BigInt typed-array Atomics#4278
Draft
andrewtdiz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2876.
This adds BigInt typed-array support to the deterministic Atomics operations that already route through the runtime:
load,store,add,sub,and,or,xor,exchange, andcompareExchange.BigInt64ArrayandBigUint64Arrayviews in the Atomics receiver validatorToBigIntoperand behavior, including rejecting Number operands while still accepting booleans and stringsNon-goals
Atomics.wait/waitAsync/notifybehavior for BigInt viewsValidation
CARGO_TARGET_DIR=/tmp/perry-atomics-bigint-check cargo check -p perry-runtime -p perry-codegen -p perry-hircargo fmt --all -- --checkCARGO_TARGET_DIR=/tmp/perry-atomics-bigint-build cargo build --release --quiet -p perry -p perry-runtime -p perry-stdlibnpm exec --yes --package=node@26 -- node --experimental-strip-types test-parity/node-suite/globals/atomics-bigint.tsPERRY_NO_AUTO_OPTIMIZE=1 /tmp/perry-atomics-bigint-build/release/perry test-parity/node-suite/globals/atomics-bigint.ts -o /tmp/perry_atomics_bigint && /tmp/perry_atomics_bigintPERRY_NO_AUTO_OPTIMIZE=1 CARGO_TARGET_DIR=/tmp/perry-atomics-bigint-build npm exec --yes --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module globals --filter atomics'git diff --check./scripts/check_file_size.sh