[codex] fix generator function constructor lookups#4273
Draft
andrewtdiz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
g.constructorresolve via the%Generator%/%AsyncGenerator%prototype'sconstructorproperty, matchingObject.getPrototypeOf(g).constructorRoot Cause
js_object_get_field_by_namehad an earlyis_closure_ptrfast path that returnedundefinedforconstructor/prototypebefore the laterGC_TYPE_CLOSUREbranch could apply the existing generator intrinsic handling. That madeg.constructor.namefail even though the generator intrinsic tower andObject.getPrototypeOf(g).constructorwere present.Validation
cargo check -p perry-runtimePERRY_NO_AUTO_OPTIMIZE=1 npm exec --yes --package=node@26 -- bash -lc 'node --version; ./run_parity_tests.sh --suite node-suite --module globals --filter generator-intrinsics'PERRY_NO_AUTO_OPTIMIZE=1 npm exec --yes --package=node@26 -- bash -lc 'node --version; ./run_parity_tests.sh --suite node-suite --module globals --filter generator-prototype'PERRY_NO_AUTO_OPTIMIZE=1 npm exec --yes --package=node@26 -- bash -lc 'node --version; ./run_parity_tests.sh --suite node-suite --module util --filter generator-predicates'cargo fmt --all -- --checkgit diff --check./scripts/check_file_size.sh