[PER-10679] Replace navigateLean with getWithChildren in the publish functionality - #1135
Open
aasandei-vsp wants to merge 1 commit into
Open
Conversation
The publish dialog polls the public route in order to find the copy that was just made. Now the polling will happen through getWithChildren. Issue: PER-10679
aasandei-vsp
force-pushed
the
PER-10476-replace-navigate-min
branch
from
August 12, 2026 08:51
bf77982 to
72c4bfc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## PER-10476-replace-navigate-min #1135 +/- ##
=================================================================
Coverage ? 52.70%
=================================================================
Files ? 354
Lines ? 12101
Branches ? 2189
=================================================================
Hits ? 6378
Misses ? 5493
Partials ? 230 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Do not merge before #1132 , this PR depends on the mappings from that specific PR
Manual test cases
Publishing a folder ⭐
The happy path
undefined, noNaN, no empty segment between slashes. The archive segment should end in-0000.Publishing a second copy of the same folder
Publishing a folder that contains subfolders and images
Internet Archive
Publishing a record — unchanged path
Sorry, this record cannot be copied or published until processing completes.— not the new generic error.Info sidebar dates for folders ⭐
(no sidebar code changed — this is the surface the timestamp mapping newly reaches)
CreatedandLast modifiedvalues.UploadedandLast modifiedare unchanged from before — records already took this path.Folder rename and date edit
(folder edits round-trip through the same conversion)
Last modifiedreflects the edit you just made, rather than a stale or blank value.Folder thumbnails and lists in gallery
(same conversion, no timestamp involvement — regression only)
Unlisted share preview