Remove replay-web feature flag - #1121
Open
slifty wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the replay-web feature-flag gating from the file viewer now that ReplayWeb is fully enabled in all environments, and updates the associated unit tests to reflect the always-on behavior for web archive records.
Changes:
- Removed
FeatureFlagServiceinjection andreplay-webflag checks fromFileViewerComponent. - Always computes
replayUrlviagetReplayUrl(), which already returnsnullfor non–web archive records. - Updated component tests to stop mocking feature flags and to validate
replayUrlbehavior based on record type.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/app/file-browser/components/file-viewer/file-viewer.component.ts | Removes replay-web feature-flag dependency and sets replayUrl unconditionally (still type-gated inside getReplayUrl()). |
| src/app/file-browser/components/file-viewer/file-viewer.component.spec.ts | Removes feature-flag mocking and updates replay URL tests to align with the new always-on behavior for web archives. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Now that the feature is complete and enabled across all environments it is time to remove the feature flag. Issue #1120 Remove ReplayWeb feature flag
slifty
force-pushed
the
1120-remove-replayweb-flag
branch
from
August 4, 2026 19:00
1db817c to
093d92e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1121 +/- ##
==========================================
+ Coverage 52.26% 52.27% +0.01%
==========================================
Files 354 354
Lines 12093 12091 -2
Branches 2186 2185 -1
==========================================
+ Hits 6320 6321 +1
+ Misses 5550 5544 -6
- Partials 223 226 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes reference to the
replay-webfeature flag now that it's deployed and enabled across all environments.Resolves #1120