[PER-10632] Add EDTF datepicker, timepicker, and timezone-dropdown components#1029
Open
aasandei-vsp wants to merge 1 commit into
Open
[PER-10632] Add EDTF datepicker, timepicker, and timezone-dropdown components#1029aasandei-vsp wants to merge 1 commit into
aasandei-vsp wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1029 +/- ##
==========================================
+ Coverage 49.97% 50.29% +0.32%
==========================================
Files 348 351 +3
Lines 11502 11687 +185
Branches 1975 2043 +68
==========================================
+ Hits 5748 5878 +130
- Misses 5569 5610 +41
- Partials 185 199 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Introduce three shared components for EDTF date/time editing: datepicker-input, timepicker-input, and timezone-dropdown. Includes related updates to EdtfService and to the shared styles (_colors.scss and _mixins.scss) to support the new components. Issue: PER-10632
89f773d to
6fc773a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The datepicker-input and timepicker-input have already been reviewed, but another fast glance would be nice.
The EDTF service is the one that's worth checking a bit more, I'd say.
The timezone-dropdown is going to be updated in a different story, but it is worth keeping the scaffolding for it, especially because I replaced the hardcoded timezones with IANA values.
These changes do not reflect in the UI at all, so no need for QA. Maybe just to check the app is loading.
Issue: PER-10632