Skip to content

[PER-10632] Add EDTF datepicker, timepicker, and timezone-dropdown components#1029

Open
aasandei-vsp wants to merge 1 commit into
mainfrom
PER-10632-add-components-edtf
Open

[PER-10632] Add EDTF datepicker, timepicker, and timezone-dropdown components#1029
aasandei-vsp wants to merge 1 commit into
mainfrom
PER-10632-add-components-edtf

Conversation

@aasandei-vsp
Copy link
Copy Markdown
Contributor

@aasandei-vsp aasandei-vsp commented May 27, 2026

The datepicker-input and timepicker-input have already been reviewed, but another fast glance would be nice.
The EDTF service is the one that's worth checking a bit more, I'd say.
The timezone-dropdown is going to be updated in a different story, but it is worth keeping the scaffolding for it, especially because I replaced the hardcoded timezones with IANA values.

These changes do not reflect in the UI at all, so no need for QA. Maybe just to check the app is loading.

Issue: PER-10632

@aasandei-vsp aasandei-vsp self-assigned this May 27, 2026
@aasandei-vsp aasandei-vsp marked this pull request as draft May 27, 2026 17:00
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

❌ Patch coverage is 76.33588% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.29%. Comparing base (aaef917) to head (6fc773a).

Files with missing lines Patch % Lines
...nts/timepicker-input/timepicker-input.component.ts 62.06% 18 Missing and 4 partials ⚠️
...nts/datepicker-input/datepicker-input.component.ts 73.84% 14 Missing and 3 partials ⚠️
...c/app/shared/services/edtf-service/edtf.service.ts 83.96% 12 Missing and 5 partials ⚠️
...s/timezone-dropdown/timezone-dropdown.component.ts 81.81% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1029      +/-   ##
==========================================
+ Coverage   49.97%   50.29%   +0.32%     
==========================================
  Files         348      351       +3     
  Lines       11502    11687     +185     
  Branches     1975     2043      +68     
==========================================
+ Hits         5748     5878     +130     
- Misses       5569     5610      +41     
- Partials      185      199      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Introduce three shared components for EDTF date/time editing:
datepicker-input, timepicker-input, and timezone-dropdown.

Includes related updates to EdtfService and to the shared styles
(_colors.scss and _mixins.scss) to support the new components.

Issue: PER-10632
@aasandei-vsp aasandei-vsp force-pushed the PER-10632-add-components-edtf branch from 89f773d to 6fc773a Compare May 28, 2026 07:59
@aasandei-vsp aasandei-vsp marked this pull request as ready for review May 28, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant